Changeset 76727 in webkit


Ignore:
Timestamp:
Jan 26, 2011 3:26:36 PM (13 years ago)
Author:
Dimitri Glazkov
Message:

2011-01-25 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

Reduce ref-count churn in shadowPseudoId.
https://bugs.webkit.org/show_bug.cgi?id=53136

Refactoring, so no new tests.

  • dom/Element.h: (WebCore::Element::shadowPseudoId): Changed signature to use const AtomicString&
  • html/ValidationMessage.cpp: (WebCore::ElementWithPseudoId::shadowPseudoId): Ditto.
  • html/shadow/SliderThumbElement.cpp: (WebCore::SliderThumbElement::shadowPseudoId): Ditto, plus moved from the header file.
  • html/shadow/SliderThumbElement.h: Ditto.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlMuteButtonElement::shadowPseudoId): Ditto. (WebCore::MediaControlVolumeSliderMuteButtonElement::shadowPseudoId): Ditto. (WebCore::MediaControlPlayButtonElement::shadowPseudoId): Ditto. (WebCore::MediaControlSeekForwardButtonElement::shadowPseudoId): Ditto. (WebCore::MediaControlSeekBackButtonElement::shadowPseudoId): Ditto. (WebCore::MediaControlRewindButtonElement::shadowPseudoId): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::shadowPseudoId): Ditto. (WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId): Ditto. (WebCore::MediaControlTimelineElement::shadowPseudoId): Ditto. (WebCore::MediaControlVolumeSliderElement::shadowPseudoId): Ditto. (WebCore::MediaControlFullscreenButtonElement::shadowPseudoId): Ditto.
  • rendering/MediaControlElements.h: Ditto.
Location:
trunk/Source/WebCore
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r76726 r76727  
     12011-01-25  Dimitri Glazkov  <dglazkov@chromium.org>
     2
     3        Reviewed by Kent Tamura.
     4
     5        Reduce ref-count churn in shadowPseudoId.
     6        https://bugs.webkit.org/show_bug.cgi?id=53136
     7
     8        Refactoring, so no new tests.
     9
     10        * dom/Element.h:
     11        (WebCore::Element::shadowPseudoId): Changed signature to use const AtomicString&
     12        * html/ValidationMessage.cpp:
     13        (WebCore::ElementWithPseudoId::shadowPseudoId): Ditto.
     14        * html/shadow/SliderThumbElement.cpp:
     15        (WebCore::SliderThumbElement::shadowPseudoId): Ditto, plus moved from the header file.
     16        * html/shadow/SliderThumbElement.h: Ditto.
     17        * rendering/MediaControlElements.cpp:
     18        (WebCore::MediaControlMuteButtonElement::shadowPseudoId): Ditto.
     19        (WebCore::MediaControlVolumeSliderMuteButtonElement::shadowPseudoId): Ditto.
     20        (WebCore::MediaControlPlayButtonElement::shadowPseudoId): Ditto.
     21        (WebCore::MediaControlSeekForwardButtonElement::shadowPseudoId): Ditto.
     22        (WebCore::MediaControlSeekBackButtonElement::shadowPseudoId): Ditto.
     23        (WebCore::MediaControlRewindButtonElement::shadowPseudoId): Ditto.
     24        (WebCore::MediaControlReturnToRealtimeButtonElement::shadowPseudoId): Ditto.
     25        (WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId): Ditto.
     26        (WebCore::MediaControlTimelineElement::shadowPseudoId): Ditto.
     27        (WebCore::MediaControlVolumeSliderElement::shadowPseudoId): Ditto.
     28        (WebCore::MediaControlFullscreenButtonElement::shadowPseudoId): Ditto.
     29        * rendering/MediaControlElements.h: Ditto.
     30
    1312011-01-26  Dave Hyatt  <hyatt@apple.com>
    232
  • trunk/Source/WebCore/dom/Element.h

    r76115 r76727  
    233233    Node* shadowRoot();
    234234    void setShadowRoot(PassRefPtr<Node>);
    235     virtual AtomicString shadowPseudoId() const;
     235    virtual const AtomicString& shadowPseudoId() const;
    236236
    237237    RenderStyle* computedStyle(PseudoId = NOPSEUDO);
     
    511511}
    512512
    513 inline AtomicString Element::shadowPseudoId() const
    514 {
    515     return AtomicString();
     513inline const AtomicString& Element::shadowPseudoId() const
     514{
     515    return nullAtom;
    516516}
    517517
  • trunk/Source/WebCore/html/ValidationMessage.cpp

    r75770 r76727  
    106106        : HTMLElement(divTag, doc)
    107107        , m_pseudoName(pseudoName) { };
    108     virtual AtomicString shadowPseudoId() const { return m_pseudoName; }
     108    virtual const AtomicString& shadowPseudoId() const { return m_pseudoName; }
    109109
    110110private:
  • trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp

    r76147 r76727  
    185185}
    186186
     187const AtomicString& SliderThumbElement::shadowPseudoId() const
     188{
     189    DEFINE_STATIC_LOCAL(AtomicString, sliderThumb, ("-webkit-slider-thumb"));
     190    return sliderThumb;
    187191}
    188192
     193}
     194
  • trunk/Source/WebCore/html/shadow/SliderThumbElement.h

    r76147 r76727  
    5454    virtual void defaultEventHandler(Event*);
    5555    virtual void detach();
    56     virtual AtomicString shadowPseudoId() const;
     56    virtual const AtomicString& shadowPseudoId() const;
    5757
    5858private:
     
    7878}
    7979
    80 inline AtomicString SliderThumbElement::shadowPseudoId() const
    81 {
    82     DEFINE_STATIC_LOCAL(AtomicString, sliderThumb, ("-webkit-slider-thumb"));
    83     return sliderThumb;
    84 }
    85 
    8680inline SliderThumbElement* toSliderThumbElement(Node* node)
    8781{
Note: See TracChangeset for help on using the changeset viewer.