Changeset 76727 in webkit
- Timestamp:
- Jan 26, 2011 3:26:36 PM (13 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r76726 r76727 1 2011-01-25 Dimitri Glazkov <dglazkov@chromium.org> 2 3 Reviewed by Kent Tamura. 4 5 Reduce ref-count churn in shadowPseudoId. 6 https://bugs.webkit.org/show_bug.cgi?id=53136 7 8 Refactoring, so no new tests. 9 10 * dom/Element.h: 11 (WebCore::Element::shadowPseudoId): Changed signature to use const AtomicString& 12 * html/ValidationMessage.cpp: 13 (WebCore::ElementWithPseudoId::shadowPseudoId): Ditto. 14 * html/shadow/SliderThumbElement.cpp: 15 (WebCore::SliderThumbElement::shadowPseudoId): Ditto, plus moved from the header file. 16 * html/shadow/SliderThumbElement.h: Ditto. 17 * rendering/MediaControlElements.cpp: 18 (WebCore::MediaControlMuteButtonElement::shadowPseudoId): Ditto. 19 (WebCore::MediaControlVolumeSliderMuteButtonElement::shadowPseudoId): Ditto. 20 (WebCore::MediaControlPlayButtonElement::shadowPseudoId): Ditto. 21 (WebCore::MediaControlSeekForwardButtonElement::shadowPseudoId): Ditto. 22 (WebCore::MediaControlSeekBackButtonElement::shadowPseudoId): Ditto. 23 (WebCore::MediaControlRewindButtonElement::shadowPseudoId): Ditto. 24 (WebCore::MediaControlReturnToRealtimeButtonElement::shadowPseudoId): Ditto. 25 (WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId): Ditto. 26 (WebCore::MediaControlTimelineElement::shadowPseudoId): Ditto. 27 (WebCore::MediaControlVolumeSliderElement::shadowPseudoId): Ditto. 28 (WebCore::MediaControlFullscreenButtonElement::shadowPseudoId): Ditto. 29 * rendering/MediaControlElements.h: Ditto. 30 1 31 2011-01-26 Dave Hyatt <hyatt@apple.com> 2 32 -
trunk/Source/WebCore/dom/Element.h
r76115 r76727 233 233 Node* shadowRoot(); 234 234 void setShadowRoot(PassRefPtr<Node>); 235 virtual AtomicStringshadowPseudoId() const;235 virtual const AtomicString& shadowPseudoId() const; 236 236 237 237 RenderStyle* computedStyle(PseudoId = NOPSEUDO); … … 511 511 } 512 512 513 inline AtomicStringElement::shadowPseudoId() const514 { 515 return AtomicString();513 inline const AtomicString& Element::shadowPseudoId() const 514 { 515 return nullAtom; 516 516 } 517 517 -
trunk/Source/WebCore/html/ValidationMessage.cpp
r75770 r76727 106 106 : HTMLElement(divTag, doc) 107 107 , m_pseudoName(pseudoName) { }; 108 virtual AtomicStringshadowPseudoId() const { return m_pseudoName; }108 virtual const AtomicString& shadowPseudoId() const { return m_pseudoName; } 109 109 110 110 private: -
trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp
r76147 r76727 185 185 } 186 186 187 const AtomicString& SliderThumbElement::shadowPseudoId() const 188 { 189 DEFINE_STATIC_LOCAL(AtomicString, sliderThumb, ("-webkit-slider-thumb")); 190 return sliderThumb; 187 191 } 188 192 193 } 194 -
trunk/Source/WebCore/html/shadow/SliderThumbElement.h
r76147 r76727 54 54 virtual void defaultEventHandler(Event*); 55 55 virtual void detach(); 56 virtual AtomicStringshadowPseudoId() const;56 virtual const AtomicString& shadowPseudoId() const; 57 57 58 58 private: … … 78 78 } 79 79 80 inline AtomicString SliderThumbElement::shadowPseudoId() const81 {82 DEFINE_STATIC_LOCAL(AtomicString, sliderThumb, ("-webkit-slider-thumb"));83 return sliderThumb;84 }85 86 80 inline SliderThumbElement* toSliderThumbElement(Node* node) 87 81 {
Note: See TracChangeset
for help on using the changeset viewer.