Changeset 76777 in webkit

Timestamp:

Jan 27, 2011 2:00:24 AM (13 years ago)

Author:

Philippe Normand

Message:

2011-01-27 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r76773.
​http://trac.webkit.org/changeset/76773
​https://bugs.webkit.org/show_bug.cgi?id=53230

breaks multiple GTK media tests (Requested by philn-tp on
#webkit).

• platform/gtk/Skipped:

2011-01-27 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r76773.
​http://trac.webkit.org/changeset/76773
​https://bugs.webkit.org/show_bug.cgi?id=53230

breaks multiple GTK media tests (Requested by philn-tp on
#webkit).

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/Skipped (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r76773.
+        http://trac.webkit.org/changeset/76773
+        https://bugs.webkit.org/show_bug.cgi?id=53230
+
+        breaks multiple GTK media tests (Requested by philn-tp on
+        #webkit).
+
+        * platform/gtk/Skipped:
+
 2011-01-27  Yuzo Fujishima  <yuzo@google.com>
 

trunk/LayoutTests/platform/gtk/Skipped

@@ -5094 +5094 @@
 http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-sync.html
 
+# This media test fails; possibly because the AAC codec is not installed on the test bots:
+# https://bugs.webkit.org/show_bug.cgi?id=53125
+media/audio-mpeg4-supported.html

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r76773.
+        http://trac.webkit.org/changeset/76773
+        https://bugs.webkit.org/show_bug.cgi?id=53230
+
+        breaks multiple GTK media tests (Requested by philn-tp on
+        #webkit).
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+        (WebCore::mimeTypeCache):
+
 2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

@@ -1385 +1385 @@
                 // These formats are supported by GStreamer, but not
                 // correctly advertised.
-                if (g_str_equal(name, "video/x-h264")) {
+                if (g_str_equal(name, "video/x-h264")
+                    || g_str_equal(name, "audio/x-m4a")) {
                     cache.add(String("video/mp4"));
-                    cached = true;
-                }
-
-                if (g_str_equal(name, "audio/x-m4a")) {
                     cache.add(String("audio/aac"));
                     cache.add(String("audio/mp4"));
-                    cache.add(String("audio/x-m4a"));
                     cached = true;
                 }