Changeset 76794 in webkit

Timestamp:

Jan 27, 2011 6:14:49 AM (13 years ago)

Author:

podivilov@chromium.org

Message:

2011-01-27 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r76789.
​http://trac.webkit.org/changeset/76789
​https://bugs.webkit.org/show_bug.cgi?id=53238

Broke GTK layout tests (Requested by podivilov on #webkit).

• inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane): (WebInspector.ScopeChainSidebarPane.prototype.update):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/ScopeChainSidebarPane.js (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r76789.
+        http://trac.webkit.org/changeset/76789
+        https://bugs.webkit.org/show_bug.cgi?id=53238
+
+        Broke GTK layout tests (Requested by podivilov on #webkit).
+
+        * inspector/front-end/ScopeChainSidebarPane.js:
+        (WebInspector.ScopeChainSidebarPane):
+        (WebInspector.ScopeChainSidebarPane.prototype.update):
+
 2011-01-27  Yury Semikhatsky  <yurys@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/ScopeChainSidebarPane.js

@@ -27 +27 @@
 {
     WebInspector.SidebarPane.call(this, WebInspector.UIString("Scope Variables"));
-    this._sections = [];
-    this._expandedSections = {};
     this._expandedProperties = [];
 }
@@ -37 +35 @@
         this.bodyElement.removeChildren();
 
+        this.sections = [];
+        this.callFrame = callFrame;
+
         if (!callFrame) {
             var infoElement = document.createElement("div");
@@ -44 +45 @@
             return;
         }
-
-        for (var i = 0; i < this._sections.length; ++i) {
-            var section = this._sections[i];
-            if (!section.title)
-                continue;
-            if (section.expanded)
-                this._expandedSections[section.title] = true;
-            else
-                delete this._expandedSections[section.title];
-        }
-
-        this._sections = [];
 
         var foundLocalScope = false;
@@ -93 +82 @@
             section.pane = this;
 
-            if (!foundLocalScope || scopeObjectProxy.isLocal || title in this._expandedSections)
+            if (!foundLocalScope || scopeObjectProxy.isLocal)
                 section.expanded = true;
 
-            this._sections.push(section);
+            this.sections.push(section);
             this.bodyElement.appendChild(section.element);
         }