Changeset 76795 in webkit

Timestamp:

Jan 27, 2011 6:22:11 AM (13 years ago)

Author:

podivilov@chromium.org

Message:

2011-01-27 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Closure and Global variable details automatically collapsing on each step through JavaScript code.
​https://bugs.webkit.org/show_bug.cgi?id=53234

• inspector/debugger-expand-scope.html:
• inspector/debugger-proto-property.html:

2011-01-27 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Closure and Global variable details automatically collapsing on each step through JavaScript code.
​https://bugs.webkit.org/show_bug.cgi?id=53234

• inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane): (WebInspector.ScopeChainSidebarPane.prototype.update):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector/debugger-expand-scope.html (modified) (2 diffs)
• LayoutTests/inspector/debugger-proto-property.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/inspector/front-end/ScopeChainSidebarPane.js (modified) (4 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-01-27  Pavel Podivilov  <podivilov@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: Closure and Global variable details automatically collapsing on each step through JavaScript code.
+        https://bugs.webkit.org/show_bug.cgi?id=53234
+
+        * inspector/debugger-expand-scope.html:
+        * inspector/debugger-proto-property.html:
+
 2011-01-27  Philippe Normand  <pnormand@igalia.com>
 

trunk/LayoutTests/inspector/debugger-expand-scope.html

@@ -36 +36 @@
         // Expand all but global scopes. Expanding global scope takes for too long
         // so we keep it collapsed.
-        var sections = WebInspector.currentPanel.sidebarPanes.scopechain.sections;
+        var sections = WebInspector.currentPanel.sidebarPanes.scopechain._sections;
         // global scope is always the last one.
         for (var i = 0; i < sections.length - 1; i++)
@@ -45 +45 @@
     function step3()
     {
-        var sections = WebInspector.currentPanel.sidebarPanes.scopechain.sections;
+        var sections = WebInspector.currentPanel.sidebarPanes.scopechain._sections;
         InspectorTest.addResult("");
         InspectorTest.addResult("Dump scope sections:");

trunk/LayoutTests/inspector/debugger-proto-property.html

@@ -31 +31 @@
     function step2(callFrames)
     {
-        var sections = WebInspector.currentPanel.sidebarPanes.scopechain.sections;
+        var sections = WebInspector.currentPanel.sidebarPanes.scopechain._sections;
         var localScope = sections[0].propertiesTreeOutline;
         var properties = [

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-01-27  Pavel Podivilov  <podivilov@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: Closure and Global variable details automatically collapsing on each step through JavaScript code.
+        https://bugs.webkit.org/show_bug.cgi?id=53234
+
+        * inspector/front-end/ScopeChainSidebarPane.js:
+        (WebInspector.ScopeChainSidebarPane):
+        (WebInspector.ScopeChainSidebarPane.prototype.update):
+
 2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebCore/inspector/front-end/ScopeChainSidebarPane.js

@@ -27 +27 @@
 {
     WebInspector.SidebarPane.call(this, WebInspector.UIString("Scope Variables"));
+    this._sections = [];
+    this._expandedSections = {};
     this._expandedProperties = [];
 }
@@ -35 +37 @@
         this.bodyElement.removeChildren();
 
-        this.sections = [];
-        this.callFrame = callFrame;
-
         if (!callFrame) {
             var infoElement = document.createElement("div");
@@ -45 +44 @@
             return;
         }
+
+        for (var i = 0; i < this._sections.length; ++i) {
+            var section = this._sections[i];
+            if (!section.title)
+                continue;
+            if (section.expanded)
+                this._expandedSections[section.title] = true;
+            else
+                delete this._expandedSections[section.title];
+        }
+
+        this._sections = [];
 
         var foundLocalScope = false;
@@ -82 +93 @@
             section.pane = this;
 
-            if (!foundLocalScope || scopeObjectProxy.isLocal)
+            if (!foundLocalScope || scopeObjectProxy.isLocal || title in this._expandedSections)
                 section.expanded = true;
 
-            this.sections.push(section);
+            this._sections.push(section);
             this.bodyElement.appendChild(section.element);
         }