Changeset 76908 in webkit


Ignore:
Timestamp:
Jan 27, 2011 7:09:48 PM (13 years ago)
Author:
mjs@apple.com
Message:

2011-01-27 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

execCommand("Paste") doesn't work in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=52785


Unskip paste tests, except the ones that still fail.

  • platform/mac-wk2/Skipped:

2011-01-27 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

execCommand("Paste") doesn't work in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=52785


Thread through the new JavaScriptCanAccessClipboard setting.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetJavaScriptCanAccessClipboard): (WKPreferencesGetJavaScriptCanAccessClipboard):
  • UIProcess/API/C/WKPreferences.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):

2011-01-27 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

execCommand("Paste") doesn't work in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=52785

Enable both of the settings needed to allow paste.


  • WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
Location:
trunk
Files:
9 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r76903 r76908  
     12011-01-27  Maciej Stachowiak  <mjs@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        execCommand("Paste") doesn't work in WebKitTestRunner
     6        https://bugs.webkit.org/show_bug.cgi?id=52785
     7       
     8        Unskip paste tests, except the ones that still fail.
     9
     10        * platform/mac-wk2/Skipped:
     11
    1122011-01-27  Emil A Eklund  <eae@chromium.org>
    213
  • trunk/LayoutTests/platform/mac-wk2/Skipped

    r76846 r76908  
    5757# WebKitTestRunner needs an implementation of eventSender
    5858# <https://bugs.webkit.org/show_bug.cgi?id=42194>
     59editing/pasteboard/emacs-ctrl-k-y-001.html
     60editing/pasteboard/drag-drop-dead-frame.html
     61editing/pasteboard/drag-drop-modifies-page.html
     62editing/pasteboard/drag-selected-image-to-contenteditable.html
     63editing/pasteboard/drop-link.html
     64editing/pasteboard/drop-text-events-sideeffect.html
     65editing/pasteboard/drop-text-events.html
     66editing/pasteboard/drop-text-without-selection.html
     67editing/pasteboard/emacs-ctrl-a-k-y.html
     68editing/pasteboard/smart-drag-drop.html
     69editing/pasteboard/smart-paste-001.html
     70editing/pasteboard/smart-paste-002.html
     71editing/pasteboard/smart-paste-003.html
     72editing/pasteboard/smart-paste-004.html
     73editing/pasteboard/smart-paste-005.html
     74editing/pasteboard/smart-paste-007.html
     75editing/pasteboard/smart-paste-008.html
     76editing/pasteboard/subframe-dragndrop-1.html
    5977inspector/timeline-event-dispatch.html
    6078fast/text/offsetForPosition-complex-fallback.html
     
    10921110media/restore-from-page-cache.html
    10931111
    1094 # execCommand("Paste") doesn't work in WebKitTestRunner
    1095 # <https://bugs.webkit.org/show_bug.cgi?id=52785>
    1096 editing/pasteboard/copy-null-characters.html
    1097 editing/execCommand/4128080-2.html
    1098 editing/execCommand/5939887.html
    1099 editing/execCommand/copy-without-selection.html
    1100 editing/execCommand/enabling-and-selection.html
    1101 editing/execCommand/paste-1.html
    1102 editing/execCommand/paste-2.html
    1103 editing/execCommand/paste-and-match-style-event.html
    1104 editing/pasteboard/19644-1.html
    1105 editing/pasteboard/19644-2.html
    1106 editing/pasteboard/3976872.html
    1107 editing/pasteboard/4076267-2.html
    1108 editing/pasteboard/4076267-3.html
    1109 editing/pasteboard/4076267.html
    1110 editing/pasteboard/4242293-1.html
    1111 editing/pasteboard/4242293.html
    1112 editing/pasteboard/4641033.html
    1113 editing/pasteboard/4922709.html
    1114 editing/pasteboard/4944770-1.html
    1115 editing/pasteboard/4989774.html
    1116 editing/pasteboard/5006779.html
    1117 editing/pasteboard/5027857.html
    1118 editing/pasteboard/5028447.html
    1119 editing/pasteboard/5065605.html
    1120 editing/pasteboard/5071074.html
    1121 editing/pasteboard/5075944-2.html
    1122 editing/pasteboard/5075944.html
    1123 editing/pasteboard/5247341.html
    1124 editing/pasteboard/5368833.html
    1125 editing/pasteboard/5478250.html
    1126 editing/pasteboard/5601583-1.html
    1127 editing/pasteboard/5665299.html
    1128 editing/pasteboard/5761530-1.html
    1129 editing/pasteboard/5780697-2.html
    1130 editing/pasteboard/block-wrappers-necessary.html
    1131 editing/pasteboard/copy-backslash-with-euc.html
    1132 editing/pasteboard/copy-in-password-field.html
    1133 editing/pasteboard/copy-paste-bidi.html
    1134 editing/pasteboard/copy-paste-float.html
    1135 editing/pasteboard/copy-resolves-urls.html
    1136 editing/pasteboard/copy-standalone-image.html
    1137 editing/pasteboard/cut-text-001.html
    1138 editing/pasteboard/display-block-on-spans.html
    1139 editing/pasteboard/drag-drop-dead-frame.html
    1140 editing/pasteboard/drag-drop-modifies-page.html
    1141 editing/pasteboard/drag-selected-image-to-contenteditable.html
    1142 editing/pasteboard/drop-link.html
    1143 editing/pasteboard/drop-text-events-sideeffect.html
    1144 editing/pasteboard/drop-text-events.html
    1145 editing/pasteboard/drop-text-without-selection.html
    1146 editing/pasteboard/emacs-ctrl-a-k-y.html
    1147 editing/pasteboard/emacs-ctrl-k-y-001.html
    1148 editing/pasteboard/get-data-text-plain-paste.html
    1149 editing/pasteboard/input-field-1.html
    1150 editing/pasteboard/page-zoom.html
    1151 editing/pasteboard/paste-4035648-fix.html
    1152 editing/pasteboard/paste-4038267-fix.html
    1153 editing/pasteboard/paste-4039777-fix.html
    1154 editing/pasteboard/paste-blockquote-before-blockquote.html
    1155 editing/pasteboard/paste-double-nested-blockquote-before-blockquote.html
    1156 editing/pasteboard/paste-event-only-once.html
    1157 editing/pasteboard/paste-line-endings-001.html
    1158 editing/pasteboard/paste-line-endings-002.html
    1159 editing/pasteboard/paste-line-endings-003.html
    1160 editing/pasteboard/paste-line-endings-004.html
    1161 editing/pasteboard/paste-line-endings-005.html
    1162 editing/pasteboard/paste-line-endings-006.html
    1163 editing/pasteboard/paste-line-endings-007.html
    1164 editing/pasteboard/paste-line-endings-008.html
    1165 editing/pasteboard/paste-line-endings-009.html
    1166 editing/pasteboard/paste-line-endings-010.html
    1167 editing/pasteboard/paste-list-001.html
    1168 editing/pasteboard/paste-list-002.html
    1169 editing/pasteboard/paste-list-003.html
    1170 editing/pasteboard/paste-list-004.html
    1171 editing/pasteboard/paste-match-style-001.html
    1172 editing/pasteboard/paste-match-style-002.html
    1173 editing/pasteboard/paste-noscript-svg.html
    1174 editing/pasteboard/paste-noscript-xhtml.xhtml
    1175 editing/pasteboard/paste-noscript.html
    1176 editing/pasteboard/paste-plaintext-user-select-none.html
    1177 editing/pasteboard/paste-pre-001.html
    1178 editing/pasteboard/paste-pre-002.html
    1179 editing/pasteboard/paste-RTFD.html
    1180 editing/pasteboard/paste-table-001.html
    1181 editing/pasteboard/paste-table-002.html
    1182 editing/pasteboard/paste-table-003.html
    1183 editing/pasteboard/paste-table-cells.html
    1184 editing/pasteboard/paste-text-001.html
    1185 editing/pasteboard/paste-text-002.html
    1186 editing/pasteboard/paste-text-003.html
    1187 editing/pasteboard/paste-text-004.html
    1188 editing/pasteboard/paste-text-005.html
    1189 editing/pasteboard/paste-text-006.html
    1190 editing/pasteboard/paste-text-007.html
    1191 editing/pasteboard/paste-text-008.html
    1192 editing/pasteboard/paste-text-009.html
    1193 editing/pasteboard/paste-text-010.html
    1194 editing/pasteboard/paste-text-011.html
    1195 editing/pasteboard/paste-text-012.html
    1196 editing/pasteboard/paste-text-013.html
    1197 editing/pasteboard/paste-text-014.html
    1198 editing/pasteboard/paste-text-015.html
    1199 editing/pasteboard/paste-text-016.html
    1200 editing/pasteboard/paste-text-017.html
    1201 editing/pasteboard/paste-text-018.html
    1202 editing/pasteboard/paste-text-019.html
    1203 editing/pasteboard/paste-text-at-tabspan-001.html
    1204 editing/pasteboard/paste-text-at-tabspan-002.html
    1205 editing/pasteboard/paste-text-at-tabspan-003.html
    1206 editing/pasteboard/paste-text-events.html
    1207 editing/pasteboard/paste-TIFF.html
    1208 editing/pasteboard/paste-unrendered-select.html
    1209 editing/pasteboard/paste-visible-script.html
    1210 editing/pasteboard/paste-xml.xhtml
    1211 editing/pasteboard/pasting-tabs.html
    1212 editing/pasteboard/select-element-1.html
    1213 editing/pasteboard/smart-drag-drop.html
    1214 editing/pasteboard/smart-paste-001.html
    1215 editing/pasteboard/smart-paste-002.html
    1216 editing/pasteboard/smart-paste-003-trailing-whitespace.html
    1217 editing/pasteboard/smart-paste-003.html
    1218 editing/pasteboard/smart-paste-004.html
    1219 editing/pasteboard/smart-paste-005.html
    1220 editing/pasteboard/smart-paste-006.html
    1221 editing/pasteboard/smart-paste-007.html
    1222 editing/pasteboard/smart-paste-008.html
    1223 editing/pasteboard/styled-element-markup.html
    1224 editing/pasteboard/subframe-dragndrop-1.html
    1225 editing/pasteboard/testcase-9507.html
    1226 editing/pasteboard/undoable-fragment-removes.html
    1227 editing/style/5065910.html
    1228 editing/style/apply-through-end-of-document.html
    1229 editing/style/font-family-with-space.html
    1230 fast/forms/plaintext-mode-1.html
    1231 fast/forms/plaintext-mode-2.html
    1232 fast/forms/textarea-paste-newline.html
    1233 http/tests/misc/copy-resolves-urls.html
    1234 platform/mac/editing/pasteboard/text-precomposed.html
    1235 
    12361112# execCommand("undo") doesn't work in WebKit2
    12371113# <rdar://problem/8862023>
     1114fast/forms/input-paste-undo.html
     1115editing/pasteboard/undoable-fragment-removes.html
     1116fast/forms/plaintext-mode-1.html
    12381117editing/deleting/delete-and-undo.html
    12391118editing/execCommand/format-block-multiple-paragraphs-in-pre.html
     
    22912170inspector/timeline-script-tag-1.html
    22922171
     2172# Crashes the WebProcess
     2173editing/pasteboard/copy-standalone-image.html
     2174
     2175# Mysterious failure after enabling paste tests
     2176platform/mac/editing/pasteboard/text-precomposed.html
     2177
    22932178### END OF (3) Unclassified failures
    22942179########################################
     
    23232208platform/mac/plugins/throw-on-dealloc.html
    23242209
     2210# WebKitTestRunner doesn't have objCPlugin
     2211# (but these tests sound like things we may want to test another way)
     2212editing/pasteboard/paste-RTFD.html
     2213editing/pasteboard/paste-TIFF.html
     2214
    23252215# WebKitTestRunner doesn't have eventSender.enableDOMUIEventLogging
    23262216platform/mac/fast/events/objc-event-api.html
  • trunk/Source/WebKit2/ChangeLog

    r76872 r76908  
     12011-01-27  Maciej Stachowiak  <mjs@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        execCommand("Paste") doesn't work in WebKitTestRunner
     6        https://bugs.webkit.org/show_bug.cgi?id=52785
     7       
     8        Thread through the new JavaScriptCanAccessClipboard setting.
     9
     10        * Shared/WebPreferencesStore.h:
     11        * UIProcess/API/C/WKPreferences.cpp:
     12        (WKPreferencesSetJavaScriptCanAccessClipboard):
     13        (WKPreferencesGetJavaScriptCanAccessClipboard):
     14        * UIProcess/API/C/WKPreferences.h:
     15        * WebProcess/WebPage/WebPage.cpp:
     16        (WebKit::WebPage::updatePreferences):
     17
    1182011-01-27  Nate Chapin  <japhet@chromium.org>
    219
  • trunk/Source/WebKit2/Shared/WebPreferencesStore.h

    r76817 r76908  
    6666    macro(PaginateDuringLayoutEnabled, paginateDuringLayoutEnabled, Bool, bool, false) \
    6767    macro(DOMPasteAllowed, domPasteAllowed, Bool, bool, false) \
     68    macro(JavaScriptCanAccessClipboard, javaScriptCanAccessClipboard, Bool, bool, false) \
    6869    macro(ShouldPrintBackgrounds, shouldPrintBackgrounds, Bool, bool, false) \
    6970    \
  • trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp

    r76654 r76908  
    460460    return toImpl(preferencesRef)->domPasteAllowed();
    461461}
     462
     463void WKPreferencesSetJavaScriptCanAccessClipboard(WKPreferencesRef preferencesRef, bool enabled)
     464{
     465    toImpl(preferencesRef)->setJavaScriptCanAccessClipboard(enabled);
     466}
     467
     468bool WKPreferencesGetJavaScriptCanAccessClipboard(WKPreferencesRef preferencesRef)
     469{
     470    return toImpl(preferencesRef)->javaScriptCanAccessClipboard();
     471}
  • trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.h

    r75979 r76908  
    147147WK_EXPORT bool WKPreferencesGetShouldPrintBackgrounds(WKPreferencesRef preferences);
    148148
     149// Defaults to false.
     150WK_EXPORT void WKPreferencesSetJavaScriptCanAccessClipboard(WKPreferencesRef preferencesRef, bool enabled);
     151WK_EXPORT bool WKPreferencesGetJavaScriptCanAccessClipboard(WKPreferencesRef preferencesRef);
     152
    149153#ifdef __cplusplus
    150154}
  • trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp

    r76824 r76908  
    12651265    settings->setPaginateDuringLayoutEnabled(store.getBoolValueForKey(WebPreferencesKey::paginateDuringLayoutEnabledKey()));
    12661266    settings->setDOMPasteAllowed(store.getBoolValueForKey(WebPreferencesKey::domPasteAllowedKey()));
     1267    settings->setJavaScriptCanAccessClipboard(store.getBoolValueForKey(WebPreferencesKey::javaScriptCanAccessClipboardKey()));
    12671268    settings->setShouldPrintBackgrounds(store.getBoolValueForKey(WebPreferencesKey::shouldPrintBackgroundsKey()));
    12681269
  • trunk/Tools/ChangeLog

    r76860 r76908  
     12011-01-27  Maciej Stachowiak  <mjs@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        execCommand("Paste") doesn't work in WebKitTestRunner
     6        https://bugs.webkit.org/show_bug.cgi?id=52785
     7
     8        Enable both of the settings needed to allow paste.
     9       
     10        * WebKitTestRunner/TestController.cpp:
     11        (WTR::TestController::resetStateToConsistentValues):
     12
    1132011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
    214
  • trunk/Tools/WebKitTestRunner/TestController.cpp

    r76811 r76908  
    347347    WKPreferencesSetDeveloperExtrasEnabled(preferences, true);
    348348    WKPreferencesSetJavaScriptCanOpenWindowsAutomatically(preferences, true);
     349    WKPreferencesSetJavaScriptCanAccessClipboard(preferences, true);
     350    WKPreferencesSetDOMPasteAllowed(preferences, true);
    349351
    350352    static WKStringRef standardFontFamily = WKStringCreateWithUTF8CString("Times");
Note: See TracChangeset for help on using the changeset viewer.