Changeset 76912 in webkit


Ignore:
Timestamp:
Jan 27, 2011 7:42:56 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76891.
http://trac.webkit.org/changeset/76891
https://bugs.webkit.org/show_bug.cgi?id=53280

Makes every layout test crash (Requested by othermaciej on
#webkit).

  • page/EventHandler.cpp:
  • page/EventHandler.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::styleDidChange):

2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76891.
http://trac.webkit.org/changeset/76891
https://bugs.webkit.org/show_bug.cgi?id=53280

Makes every layout test crash (Requested by othermaciej on
#webkit).

  • Misc/WebIconDatabase.mm: (-[ThreadEnabler threadEnablingSelector:]): (importToWebCoreFormat):
Location:
trunk/Source
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r76911 r76912  
     12011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r76891.
     4        http://trac.webkit.org/changeset/76891
     5        https://bugs.webkit.org/show_bug.cgi?id=53280
     6
     7        Makes every layout test crash (Requested by othermaciej on
     8        #webkit).
     9
     10        * page/EventHandler.cpp:
     11        * page/EventHandler.h:
     12        * rendering/RenderObject.cpp:
     13        (WebCore::RenderObject::styleDidChange):
     14
    1152011-01-27  Ryosuke Niwa  <rniwa@webkit.org>
    216
  • trunk/Source/WebCore/page/EventHandler.cpp

    r76891 r76912  
    11/*
    2  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
     2 * Copyright (C) 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
    33 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
    44 *
     
    21532153}
    21542154
    2155 void EventHandler::dispatchFakeMouseMoveEventSoon()
    2156 {
    2157     if (m_mousePressed)
    2158         return;
    2159 
    2160     if (!m_fakeMouseMoveEventTimer.isActive())
    2161         m_fakeMouseMoveEventTimer.startOneShot(fakeMouseMoveInterval);
    2162 }
    2163 
    21642155void EventHandler::dispatchFakeMouseMoveEventSoonInQuad(const FloatQuad& quad)
    21652156{
  • trunk/Source/WebCore/page/EventHandler.h

    r76891 r76912  
    11/*
    2  * Copyright (C) 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
     2 * Copyright (C) 2006, 2007, 2009, 2010 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    109109    void updateAutoscrollRenderer();
    110110
    111     void dispatchFakeMouseMoveEventSoon();
    112111    void dispatchFakeMouseMoveEventSoonInQuad(const FloatQuad&);
    113112
  • trunk/Source/WebCore/rendering/RenderObject.cpp

    r76891 r76912  
    44 *           (C) 2000 Dirk Mueller (mueller@kde.org)
    55 *           (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
    6  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
     6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
    77 * Copyright (C) 2009 Google Inc. All rights reserved.
    88 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
     
    3232#include "Chrome.h"
    3333#include "ContentData.h"
    34 #include "CursorList.h"
    3534#include "DashArray.h"
    3635#include "EditingBoundary.h"
     
    18611860}
    18621861
    1863 static bool areNonIdenticalCursorListsEqual(const RenderStyle* a, const RenderStyle* b)
    1864 {
    1865     ASSERT(a->cursors() != b->cursors());
    1866     return a->cursors() && b->cursors() && *a->cursors() == *b->cursors();
    1867 }
    1868 
    1869 static inline bool areCursorsEqual(const RenderStyle* a, const RenderStyle* b)
    1870 {
    1871     return a->cursor() == b->cursor() && (a->cursors() == b->cursors() || areNonIdenticalCursorListsEqual(a, b));
    1872 }
    1873 
    18741862void RenderObject::styleDidChange(StyleDifference diff, const RenderStyle* oldStyle)
    18751863{
     
    18971885    // Don't check for repaint here; we need to wait until the layer has been
    18981886    // updated by subclasses before we know if we have to repaint (in setStyle()).
    1899 
    1900     if (!areCursorsEqual(oldStyle, style())) {
    1901         if (Frame* frame = this->frame())
    1902             frame->eventHandler()->dispatchFakeMouseMoveEventSoon();
    1903     }
    19041887}
    19051888
  • trunk/Source/WebKit/mac/ChangeLog

    r76872 r76912  
     12011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r76891.
     4        http://trac.webkit.org/changeset/76891
     5        https://bugs.webkit.org/show_bug.cgi?id=53280
     6
     7        Makes every layout test crash (Requested by othermaciej on
     8        #webkit).
     9
     10        * Misc/WebIconDatabase.mm:
     11        (-[ThreadEnabler threadEnablingSelector:]):
     12        (importToWebCoreFormat):
     13
    1142011-01-27  Nate Chapin  <japhet@chromium.org>
    215
  • trunk/Source/WebKit/mac/Misc/WebIconDatabase.mm

    r76891 r76912  
    560560@end
    561561
    562 @interface ThreadEnabler : NSObject
     562@interface ThreadEnabler : NSObject {
     563}
    563564+ (void)enableThreading;
     565
    564566- (void)threadEnablingSelector:(id)arg;
    565567@end
     
    569571- (void)threadEnablingSelector:(id)arg
    570572{
     573    return;
    571574}
    572575
     
    587590        [ThreadEnabler enableThreading];
    588591    ASSERT([NSThread isMultiThreaded]);   
    589 
     592   
    590593    // Get the directory the old icon database *should* be in
    591594    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
Note: See TracChangeset for help on using the changeset viewer.