Changeset 76929 in webkit


Ignore:
Timestamp:
Jan 28, 2011 4:46:50 AM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-01-28 Ilya Sherman <​isherman@chromium.org>

Reviewed by Andreas Kling.

Const-correct HTMLSelectElement and WebSelectElement
​https://bugs.webkit.org/show_bug.cgi?id=53293

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::value): const.
  • html/HTMLSelectElement.h:

2011-01-28 Ilya Sherman <​isherman@chromium.org>

Reviewed by Andreas Kling.

Const-correct HTMLSelectElement and WebSelectElement
​https://bugs.webkit.org/show_bug.cgi?id=53293

  • public/WebSelectElement.h:
  • src/WebSelectElement.cpp: (WebKit::WebSelectElement::value): const. (WebKit::WebSelectElement::listItems): const.
Location:
trunk/Source
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r76925 r76929  
     12011-01-28  Ilya Sherman  <isherman@chromium.org>
     2
     3        Reviewed by Andreas Kling.
     4
     5        Const-correct HTMLSelectElement and WebSelectElement
     6        https://bugs.webkit.org/show_bug.cgi?id=53293
     7
     8        * html/HTMLSelectElement.cpp:
     9        (WebCore::HTMLSelectElement::value): const.
     10        * html/HTMLSelectElement.h:
     11
    1122011-01-28  Sheriff Bot  <webkit.review.bot@gmail.com>
    213

  • trunk/Source/WebCore/html/HTMLSelectElement.cpp

    r74841 r76929  
    207207}
    208208
    209 String HTMLSelectElement::value()
     209String HTMLSelectElement::value() const
    210210{
    211211    const Vector<Element*>& items = listItems();

  • trunk/Source/WebCore/html/HTMLSelectElement.h

    r76115 r76929  
    5656    void remove(HTMLOptionElement*);
    5757
    58     String value();
     58    String value() const;
    5959    void setValue(const String&);
    6060

  • trunk/Source/WebKit/chromium/ChangeLog

    r76889 r76929  
     12011-01-28  Ilya Sherman  <isherman@chromium.org>
     2
     3        Reviewed by Andreas Kling.
     4
     5        Const-correct HTMLSelectElement and WebSelectElement
     6        https://bugs.webkit.org/show_bug.cgi?id=53293
     7
     8        * public/WebSelectElement.h:
     9        * src/WebSelectElement.cpp:
     10        (WebKit::WebSelectElement::value): const.
     11        (WebKit::WebSelectElement::listItems): const.
     12
    1132011-01-27  Finnur Thorarinsson  <finnur.webkit@gmail.com>
    214

  • trunk/Source/WebKit/chromium/public/WebSelectElement.h

    r75106 r76929  
    5656
    5757    WEBKIT_API void setValue(const WebString&);
    58     WEBKIT_API WebString value();
    59     WEBKIT_API WebVector<WebElement> listItems();
     58    WEBKIT_API WebString value() const;
     59    WEBKIT_API WebVector<WebElement> listItems() const;
    6060
    6161#if WEBKIT_IMPLEMENTATION

  • trunk/Source/WebKit/chromium/src/WebSelectElement.cpp

    r63401 r76929  
    4747}
    4848
    49 WebString WebSelectElement::value()
     49WebString WebSelectElement::value() const
    5050{
    51     return unwrap<HTMLSelectElement>()->value();
     51    return constUnwrap<HTMLSelectElement>()->value();
    5252}
    5353
    54 WebVector<WebElement> WebSelectElement::listItems()
     54WebVector<WebElement> WebSelectElement::listItems() const
    5555{
    56     const Vector<Element*>& sourceItems = unwrap<HTMLSelectElement>()->listItems();
     56    const Vector<Element*>& sourceItems = constUnwrap<HTMLSelectElement>()->listItems();
    5757    WebVector<WebElement> items(sourceItems.size());
    5858    for (size_t i = 0; i < sourceItems.size(); ++i)
Note: See TracChangeset for help on using the changeset viewer.