Changeset 77123 in webkit


Ignore:
Timestamp:
Jan 31, 2011 5:59:15 AM (13 years ago)
Author:
kov@webkit.org
Message:

2011-01-31 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] REGRESSION: http/tests/media/video-{cookie,referer}.html failing
​https://bugs.webkit.org/show_bug.cgi?id=53379

Remove left over mentions of HAVE_SOUP_2_29_90, and apply the
dependency on newer soup to efl as well.

  • Source/cmake/OptionsEfl.cmake:

2011-01-31 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] REGRESSION: http/tests/media/video-{cookie,referer}.html failing
​https://bugs.webkit.org/show_bug.cgi?id=53379

Unskip tests that pass again.

  • platform/gtk/Skipped:

2011-01-31 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] REGRESSION: http/tests/media/video-{cookie,referer}.html failing
​https://bugs.webkit.org/show_bug.cgi?id=53379

Remove left over #ifdef's. I thought all of the conditional code
had been freed from the condition, but I forgot to check DRT.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAlwaysAcceptCookies):
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/ChangeLog

    r77073 r77123  
     12011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
     2
     3        Reviewed by Xan Lopez.
     4
     5        [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
     6        https://bugs.webkit.org/show_bug.cgi?id=53379
     7
     8        Remove left over mentions of HAVE_SOUP_2_29_90, and apply the
     9        dependency on newer soup to efl as well.
     10
     11        * Source/cmake/OptionsEfl.cmake:
     12
    1132011-01-29  Daniel Bates  <dbates@rim.com>
    214

  • trunk/LayoutTests/ChangeLog

    r77120 r77123  
     12011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
     2
     3        Reviewed by Xan Lopez.
     4
     5        [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
     6        https://bugs.webkit.org/show_bug.cgi?id=53379
     7
     8        Unskip tests that pass again.
     9
     10        * platform/gtk/Skipped:
     11
    1122011-01-31  Yury Semikhatsky  <yurys@chromium.org>
    213

  • trunk/LayoutTests/platform/gtk/Skipped

    r77069 r77123  
    50995099# https://bugs.webkit.org/show_bug.cgi?id=53247
    51005100media/audio-delete-while-slider-thumb-clicked.html
    5101 
    5102 # https://bugs.webkit.org/show_bug.cgi?id=53379
    5103 http/tests/media/video-cookie.html
    5104 http/tests/media/video-referer.html

  • trunk/Source/cmake/OptionsEfl.cmake

    r75403 r77123  
    115115    MESSAGE("Forcing Glib support")
    116116  ENDIF ()
    117   FIND_PACKAGE(LibSoup2 2.28.2 REQUIRED)
     117  FIND_PACKAGE(LibSoup2 2.33.4 REQUIRED)
    118118  SET(WTF_USE_SOUP 1)
    119119  ADD_DEFINITIONS(-DWTF_USE_SOUP=1)
    120 
    121   IF (LIBSOUP24_VERSION VERSION_LESS 2.29.90)
    122   ELSE (LIBSOUP24_VERSION VERSION_LESS 2.29.90)
    123       SET(HAVE_LIBSOUP_2_29_90 1)
    124       ADD_DEFINITIONS(-DHAVE_LIBSOUP_2_29_90=1)
    125   ENDIF ()
    126120ELSE ()
    127121  FIND_PACKAGE(CURL REQUIRED)

  • trunk/Tools/ChangeLog

    r77096 r77123  
     12011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
     2
     3        Reviewed by Xan Lopez.
     4
     5        [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
     6        https://bugs.webkit.org/show_bug.cgi?id=53379
     7
     8        Remove left over #ifdef's. I thought all of the conditional code
     9        had been freed from the condition, but I forgot to check DRT.
     10
     11        * DumpRenderTree/gtk/DumpRenderTree.cpp:
     12        (resetDefaultsToConsistentValues):
     13        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
     14        (LayoutTestController::setAlwaysAcceptCookies):
     15
    1162011-01-30  Dirk Pranke  <dpranke@chromium.org>
    217

  • trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp

    r75729 r77123  
    433433    webkit_web_back_forward_list_clear(list);
    434434
    435 #ifdef HAVE_LIBSOUP_2_29_90
    436435    SoupSession* session = webkit_get_default_session();
    437436    SoupCookieJar* jar = reinterpret_cast<SoupCookieJar*>(soup_session_get_feature(session, SOUP_TYPE_COOKIE_JAR));
    … …  
    441440    if (jar)
    442441        g_object_set(G_OBJECT(jar), SOUP_COOKIE_JAR_ACCEPT_POLICY, SOUP_COOKIE_JAR_ACCEPT_NO_THIRD_PARTY, NULL);
    443 #endif
    444442
    445443    setlocale(LC_ALL, "");

  • trunk/Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp

    r73938 r77123  
    231231void LayoutTestController::setAlwaysAcceptCookies(bool alwaysAcceptCookies)
    232232{
    233 #ifdef HAVE_LIBSOUP_2_29_90
    234233    SoupSession* session = webkit_get_default_session();
    235234    SoupCookieJar* jar = reinterpret_cast<SoupCookieJar*>(soup_session_get_feature(session, SOUP_TYPE_COOKIE_JAR));
    … …  
    252251
    253252    g_object_set(G_OBJECT(jar), SOUP_COOKIE_JAR_ACCEPT_POLICY, policy, NULL);
    254 #endif
    255253}
    256254
Note: See TracChangeset for help on using the changeset viewer.