Changeset 77138 in webkit


Ignore:
Timestamp:
Jan 31, 2011 10:06:25 AM (13 years ago)
Author:
tony@chromium.org
Message:

2011-01-31 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

mac DRT should report RTL scroll offset relative to top right corner
​https://bugs.webkit.org/show_bug.cgi?id=53324

Remove scroll offsets since these are at the origin.

  • platform/mac/fast/block/basic/truncation-rtl-expected.txt:
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
  • platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
  • platform/mac/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:

2011-01-31 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

mac DRT should report RTL scroll offset relative to top right corner
​https://bugs.webkit.org/show_bug.cgi?id=53324

  • DumpRenderTree/mac/DumpRenderTree.mm: (dumpFrameScrollPosition):
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r77136 r77138  
     12011-01-31  Tony Chang  <tony@chromium.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        mac DRT should report RTL scroll offset relative to top right corner
     6        https://bugs.webkit.org/show_bug.cgi?id=53324
     7
     8        Remove scroll offsets since these are at the origin.
     9
     10        * platform/mac/fast/block/basic/truncation-rtl-expected.txt:
     11        * platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
     12        * platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
     13        * platform/mac/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:
     14
    1152011-01-31  Yury Semikhatsky  <yurys@chromium.org>
    216

  • trunk/LayoutTests/platform/mac/fast/block/basic/truncation-rtl-expected.txt

    r72852 r77138  
    2929          text run at (617,109) width 4 RTL: "."
    3030          text run at (621,109) width 380: "Nullam non nunc ligula. Proin sed ante sem, id rutrum purus"
    31 scrolled to 210,0

  • trunk/LayoutTests/platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt

    r76731 r77138  
    29132913            text run at (1998,0) width 33: "\x{308B}\x{3002}"
    29142914          RenderBR {BR} at (1998,33) size 18x0
    2915 scrolled to 4339,0

  • trunk/LayoutTests/platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt

    r76726 r77138  
    162162        text run at (360,0) width 110: "This is some text."
    163163      RenderBR {BR} at (374,110) size 0x0
    164 scrolled to 8,0

  • trunk/LayoutTests/platform/mac/fast/multicol/vertical-rl/float-paginate-complex-expected.txt

    r76726 r77138  
    257257        text run at (586,0) width 110: "This is some text."
    258258      RenderBR {BR} at (600,110) size 0x0
    259 scrolled to 895,0

  • trunk/Tools/ChangeLog

    r77130 r77138  
     12011-01-31  Tony Chang  <tony@chromium.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        mac DRT should report RTL scroll offset relative to top right corner
     6        https://bugs.webkit.org/show_bug.cgi?id=53324
     7
     8        * DumpRenderTree/mac/DumpRenderTree.mm:
     9        (dumpFrameScrollPosition):
     10
    1112011-01-31  Zoltan Horvath  <zoltan@webkit.org>
    212

  • trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm

    r73938 r77138  
    754754static void dumpFrameScrollPosition(WebFrame *f)
    755755{
    756     NSPoint scrollPosition = [[[[f frameView] documentView] superview] bounds].origin;
     756    WebScriptObject* scriptObject = [f windowObject];
     757    NSPoint scrollPosition = NSMakePoint(
     758        [[scriptObject valueForKey:@"pageXOffset"] floatValue],
     759        [[scriptObject valueForKey:@"pageYOffset"] floatValue]);
    757760    if (ABS(scrollPosition.x) > 0.00000001 || ABS(scrollPosition.y) > 0.00000001) {
    758761        if ([f parentFrame] != nil)
Note: See TracChangeset for help on using the changeset viewer.