Changeset 77235 in webkit
- Timestamp:
- Feb 1, 2011 1:58:30 AM (13 years ago)
- Location:
- trunk/Source
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r77234 r77235 1 2011-02-01 Mario Sanchez Prada <msanchez@igalia.com> 2 3 Reviewed by Martin Robinson. 4 5 [Gtk] atk_text_set_caret_offset fails for list items 6 https://bugs.webkit.org/show_bug.cgi?id=53388 7 8 Allow using text ranges across list items. 9 10 * accessibility/gtk/AccessibilityObjectAtk.cpp: 11 (WebCore::AccessibilityObject::allowsTextRanges): Add list items 12 to the list of accessibility objects supporting text ranges. 13 1 14 2011-02-01 Mario Sanchez Prada <msanchez@igalia.com> 2 15 -
trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp
r68023 r77235 106 106 bool AccessibilityObject::allowsTextRanges() const 107 107 { 108 return isTextControl() || isWebArea() || isGroup() || isLink() || isHeading() ;108 return isTextControl() || isWebArea() || isGroup() || isLink() || isHeading() || isListItem(); 109 109 } 110 110 -
trunk/Source/WebKit/gtk/ChangeLog
r77234 r77235 1 2011-02-01 Mario Sanchez Prada <msanchez@igalia.com> 2 3 Reviewed by Martin Robinson. 4 5 [Gtk] atk_text_set_caret_offset fails for list items 6 https://bugs.webkit.org/show_bug.cgi?id=53388 7 8 Update unit test to check the fix for this bug. 9 10 * tests/testatk.c: 11 (testWebkitAtkCaretOffsets): Ensure setting the caret in a list 12 item through the AtkText interface is possible. 13 1 14 2011-02-01 Mario Sanchez Prada <msanchez@igalia.com> 2 15 -
trunk/Source/WebKit/gtk/tests/testatk.c
r77234 r77235 293 293 g_assert_cmpint(result, ==, FALSE); 294 294 295 /* TODO: Check here that it's possible to set the caret in the 296 middle of the text for a list item when fixing bug 53388. 297 https://bugs.webkit.org/show_bug.cgi?id=53388 */ 295 /* It should be possible to place the caret inside an item's text. */ 296 result = atk_text_set_caret_offset(ATK_TEXT(listItem), 5); 297 g_assert_cmpint(result, ==, TRUE); 298 299 /* Uncomment the following two lines when fixing bug 53436. */ 300 /* offset = atk_text_get_caret_offset(ATK_TEXT(listItem)); */ 301 /* g_assert_cmpint(offset, ==, 5); */ 298 302 299 303 AtkObject* panel = atk_object_ref_accessible_child(object, 3);
Note: See TracChangeset
for help on using the changeset viewer.