Changeset 77249 in webkit

Timestamp:

Feb 1, 2011 6:53:15 AM (13 years ago)

Author:

apavlov@chromium.org

Message:

2011-02-01 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Wrongly labelled context-menu item for links in Web Inspector's side-pane
​https://bugs.webkit.org/show_bug.cgi?id=53482

• English.lproj/localizedStrings.js:
• inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
• inspector/front-end/inspector.js: (WebInspector.resourceForURL): (WebInspector.openLinkExternallyLabel):

2011-02-01 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Wrongly labelled context-menu item for links in Web Inspector's side-pane
​https://bugs.webkit.org/show_bug.cgi?id=53482

• src/js/DevTools.js: (WebInspector.openLinkExternallyLabel): Override to customize a context menu item label

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/English.lproj/localizedStrings.js (modified) (previous)
• WebCore/inspector/front-end/ElementsPanel.js (modified) (1 diff)
• WebCore/inspector/front-end/inspector.js (modified) (1 diff)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/src/js/DevTools.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-02-01  Alexander Pavlov  <apavlov@chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: [Chromium] Wrongly labelled context-menu item for links in Web Inspector's side-pane
+        https://bugs.webkit.org/show_bug.cgi?id=53482
+
+        * English.lproj/localizedStrings.js:
+        * inspector/front-end/ElementsPanel.js:
+        (WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
+        * inspector/front-end/inspector.js:
+        (WebInspector.resourceForURL):
+        (WebInspector.openLinkExternallyLabel):
+
 2011-02-01  Anton Muhin  <antonm@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/ElementsPanel.js

@@ -256 +256 @@
 
         // Add resource-related actions.
-        // Keep these consistent with those added in WebInspector.StylesSidebarPane.prototype._populateHrefContextMenu().
-        contextMenu.appendItem(WebInspector.UIString("Open Link in New Window"), WebInspector.openResource.bind(null, resourceURL, false));
+        contextMenu.appendItem(WebInspector.openLinkExternallyLabel(), WebInspector.openResource.bind(null, resourceURL, false));
         if (WebInspector.resourceForURL(resourceURL))
             contextMenu.appendItem(WebInspector.UIString("Open Link in Resources Panel"), WebInspector.openResource.bind(null, resourceURL, true));

trunk/Source/WebCore/inspector/front-end/inspector.js

@@ -450 +450 @@
     {
         return this.resourceTreeModel.resourceForURL(url);
+    },
+
+    openLinkExternallyLabel: function()
+    {
+        return WebInspector.UIString("Open Link in New Window");
     }
 }

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2011-02-01  Alexander Pavlov  <apavlov@chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: [Chromium] Wrongly labelled context-menu item for links in Web Inspector's side-pane
+        https://bugs.webkit.org/show_bug.cgi?id=53482
+
+        * src/js/DevTools.js:
+        (WebInspector.openLinkExternallyLabel): Override to customize a context menu item label
+
 2011-02-01  Darin Fisher  <darin@chromium.org>
 

trunk/Source/WebKit/chromium/src/js/DevTools.js

@@ -90 +90 @@
 
 
+/*
+ * This label must be kept consistent with that in English.lproj/localizedStrings.js
+ *
+ * http://code.google.com/p/chromium/issues/detail?id=61302 requires a custom label for Chromium,
+ * since its behavior is different.
+ */
+WebInspector.openLinkExternallyLabel = function()
+{
+    return WebInspector.UIString("Open Link in New Tab");
+};
+
+
 /** Pending WebKit upstream by apavlov). Fixes iframe vs drag problem. */
 (function()