Changeset 77633 in webkit

Timestamp:

Feb 4, 2011 9:07:47 AM (13 years ago)

Author:

Adam Roben

Message:

Link to Mac crash logs from results.html

Fixes <​http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
results.html

Reviewed by David Kilzer.

• Scripts/old-run-webkit-tests:

(captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/old-run-webkit-tests (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-02-04  Adam Roben  <aroben@apple.com>
+
+        Link to Mac crash logs from results.html
+
+        Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
+        results.html
+
+        Reviewed by David Kilzer.
+
+        * Scripts/old-run-webkit-tests:
+        (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
+        ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
+
 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
 

trunk/Tools/Scripts/old-run-webkit-tests

@@ -1752 +1752 @@
 
     my $crashLog;
+
+    my $glob;
     if (isCygwin()) {
-        # We assume that the newest crash log in $testResultsDirectory is the one that corresponds to the crash that just occurred.
-        my $newestCrashLog = findNewestFileMatchingGlob(File::Spec->catfile($testResultsDirectory, $windowsCrashLogFilePrefix . "*.txt"));
-
+        $glob = File::Spec->catfile($testResultsDirectory, $windowsCrashLogFilePrefix . "*.txt");
+    } elsif (isAppleMacWebKit()) {
+        $glob = File::Spec->catfile("~", "Library", "Logs", "CrashReporter", $dumpToolName . "_*.crash");
+
+        # Even though the dump tool has exited, CrashReporter might still be running. We need to
+        # wait for it to exit to ensure it has saved its crash log to disk. For simplicitly, we'll
+        # assume that the ReportCrash process with the highest PID is the one we want.
+        if (my @reportCrashPIDs = sort map { /^\s*(\d+)/; $1 } grep { /ReportCrash/ } `/bin/ps x`) {
+            my $reportCrashPID = $reportCrashPIDs[$#reportCrashPIDs];
+            # We use kill instead of waitpid because ReportCrash is not one of our child processes.
+            usleep(250000) while kill(0, $reportCrashPID) > 0;
+        }
+    }
+
+    # We assume that the newest crash log in matching the glob is the one that corresponds to the crash that just occurred.
+    if (my $newestCrashLog = findNewestFileMatchingGlob($glob)) {
         # The crash log must have been created after this script started running.
         $crashLog = $newestCrashLog if -M $newestCrashLog < 0;
     }
+
     return unless $crashLog;