Changeset 77763 in webkit


Ignore:
Timestamp:
Feb 6, 2011 2:35:28 AM (13 years ago)
Author:
mjs@apple.com
Message:

2011-02-06 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
https://bugs.webkit.org/show_bug.cgi?id=42690
<rdar://problem/8213851>

  • platform/mac-wk2/Skipped: Unskip tests that now pass, except for the ones that mysteriously fail.

2011-02-06 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
https://bugs.webkit.org/show_bug.cgi?id=42690
<rdar://problem/8213851>

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::willSendRequestForFrame):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::LayoutTestController):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: (WTR::LayoutTestController::willSendRequestReturnsNull): (WTR::LayoutTestController::setWillSendRequestReturnsNull):
Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r77758 r77763  
     12011-02-06  Maciej Stachowiak  <mjs@apple.com>
     2
     3        Reviewed by Dan Bernstein.
     4
     5        WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
     6        https://bugs.webkit.org/show_bug.cgi?id=42690
     7        <rdar://problem/8213851>
     8
     9        * platform/mac-wk2/Skipped: Unskip tests that now pass, except for the ones that
     10        mysteriously fail.
     11
    1122011-02-05  Dimitri Glazkov  <dglazkov@chromium.org>
    213
  • trunk/LayoutTests/platform/mac-wk2/Skipped

    r77728 r77763  
    16111611editing/execCommand/toggle-compound-styles.html
    16121612
    1613 # WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
    1614 # <https://bugs.webkit.org/show_bug.cgi?id=42690>
    1615 fast/loader/onload-willSendRequest-null-for-frame.html
    1616 fast/loader/onload-willSendRequest-null-for-script.html
    1617 fast/loader/subresource-willSendRequest-null.html
    1618 plugins/plugin-document-willSendRequest-null.html
    1619 fast/loader/willSendRequest-null-for-preload.html
    1620 
    16211613# WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
    16221614# <https://bugs.webkit.org/show_bug.cgi?id=42691>
     
    21782170platform/mac/editing/pasteboard/text-precomposed.html
    21792171
     2172# Unexplained failures after implementing willSendRequestReturnsNull
     2173fast/loader/onload-willSendRequest-null-for-frame.html
     2174plugins/plugin-document-willSendRequest-null.html
     2175
    21802176### END OF (3) Unclassified failures
    21812177########################################
  • trunk/Tools/ChangeLog

    r77745 r77763  
     12011-02-06  Maciej Stachowiak  <mjs@apple.com>
     2
     3        Reviewed by Dan Bernstein.
     4
     5        WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
     6        https://bugs.webkit.org/show_bug.cgi?id=42690
     7        <rdar://problem/8213851>
     8
     9        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
     10        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
     11        (WTR::InjectedBundlePage::willSendRequestForFrame):
     12        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
     13        (WTR::LayoutTestController::LayoutTestController):
     14        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
     15        (WTR::LayoutTestController::willSendRequestReturnsNull):
     16        (WTR::LayoutTestController::setWillSendRequestReturnsNull):
     17
    1182011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
    219
  • trunk/Tools/Scripts/webkitpy/common/net/layouttestresults.py

    r75125 r77763  
    5252    crash_key = u'Tests that caused the DumpRenderTree tool to crash:'
    5353    missing_key = u'Tests that had no expected results (probably new):'
     54    webprocess_crash_key = u'Tests that caused the Web process to crash:'
    5455
    5556    expected_keys = [
     
    5758        fail_key,
    5859        crash_key,
     60        webprocess_crash_key,
    5961        timeout_key,
    6062        missing_key,
     
    8789            return cls._failures_from_fail_row(row)
    8890        if table_title == cls.crash_key:
     91            return [test_failures.FailureCrash()]
     92        if table_title == cls.webprocess_crash_key:
    8993            return [test_failures.FailureCrash()]
    9094        if table_title == cls.timeout_key:
  • trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl

    r77042 r77763  
    8888
    8989        void setPOSIXLocale(in DOMString locale);
     90
     91        void setWillSendRequestReturnsNull(in boolean flag);
    9092    };
    9193
  • trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp

    r77611 r77763  
    577577WKURLRequestRef InjectedBundlePage::willSendRequestForFrame(WKBundlePageRef, WKBundleFrameRef, uint64_t, WKURLRequestRef request, WKURLResponseRef)
    578578{
     579    if (InjectedBundle::shared().isTestRunning() && InjectedBundle::shared().layoutTestController()->willSendRequestReturnsNull())
     580        return 0;
     581
    579582    return request;
    580583}
  • trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp

    r77042 r77763  
    9898    , m_testRepaint(false)
    9999    , m_testRepaintSweepHorizontally(false)
     100    , m_willSendRequestReturnsNull(false)
    100101{
    101102    platformInitialize();
  • trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h

    r77042 r77763  
    134134    void setPOSIXLocale(JSStringRef);
    135135
     136    bool willSendRequestReturnsNull() { return m_willSendRequestReturnsNull; }
     137    void setWillSendRequestReturnsNull(bool f) { m_willSendRequestReturnsNull = f; }
     138
    136139private:
    137140    static const double waitToDumpWatchdogTimerInterval;
     
    156159    bool m_testRepaintSweepHorizontally;
    157160
     161    bool m_willSendRequestReturnsNull;
     162
    158163    PlatformTimerRef m_waitToDumpWatchdogTimer;
    159164};
Note: See TracChangeset for help on using the changeset viewer.