Changeset 78127 in webkit
- Timestamp:
- Feb 9, 2011 1:53:57 PM (13 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r78103 r78127 1 2011-02-09 Adam Barth <abarth@webkit.org> 2 3 Reviewed by Eric Seidel. 4 5 REGRESSION(HTML 5): HTMLDocumentParser does not report html parse errors to the console 6 https://bugs.webkit.org/show_bug.cgi?id=41187 7 8 Wire up a basic HTML parse error message. There's a lot of room for 9 improvement in this area, but this is a start. 10 11 No tests! See https://bugs.webkit.org/show_bug.cgi?id=54134 12 13 * html/parser/HTMLDocumentParser.h: 14 * html/parser/HTMLTreeBuilder.cpp: 15 (WebCore::HTMLTreeBuilder::parseError): 16 * html/parser/HTMLTreeBuilder.h: 17 1 18 2011-02-09 Naoki Takano <takano.naoki@gmail.com> 2 19 -
trunk/Source/WebCore/html/parser/HTMLDocumentParser.h
r76980 r78127 77 77 78 78 virtual TextPosition0 textPosition() const; 79 virtual int lineNumber() const; 80 79 81 virtual void suspendScheduledTasks(); 80 82 virtual void resumeScheduledTasks(); … … 101 103 virtual bool isExecutingScript() const; 102 104 virtual void executeScriptsWaitingForStylesheets(); 103 virtual int lineNumber() const;104 105 105 106 // HTMLScriptRunnerHost -
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp
r77062 r78127 28 28 29 29 #include "Comment.h" 30 #include "DOMWindow.h" 30 31 #include "DocumentFragment.h" 31 32 #include "DocumentType.h" … … 2808 2809 } 2809 2810 2811 void HTMLTreeBuilder::parseError(AtomicHTMLToken&) 2812 { 2813 DEFINE_STATIC_LOCAL(String, parseErrorMessage, ("HTML parse error (recovered gracefully)")); 2814 2815 if (!m_reportErrors) 2816 return; 2817 2818 DOMWindow* domWindow = m_document->domWindow(); 2819 if (!domWindow) 2820 return; 2821 2822 domWindow->console()->addMessage(HTMLMessageSource, LogMessageType, WarningMessageLevel, parseErrorMessage, m_parser->lineNumber(), m_document->url().string()); 2823 } 2824 2810 2825 bool HTMLTreeBuilder::scriptEnabled(Frame* frame) 2811 2826 { -
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.h
r77053 r78127 184 184 bool m_framesetOk; 185 185 186 // FIXME: Implement error reporting. 187 void parseError(AtomicHTMLToken&) { } 186 void parseError(AtomicHTMLToken&); 188 187 189 188 InsertionMode insertionMode() const { return m_insertionMode; }
Note: See TracChangeset
for help on using the changeset viewer.