Changeset 78469 in webkit

Timestamp:

Feb 14, 2011 5:13:49 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-02-14 Kenichi Ishibashi <​bashi@chromium.org>

Reviewed by Andreas Kling.

css style="max-width:none" works wrong
​https://bugs.webkit.org/show_bug.cgi?id=53743

Adds a test to ensure style 'max-width: none' works correctly.

• fast/css/max-width-none-expected.txt: Added.
• fast/css/max-width-none.html: Added.

2011-02-14 Kenichi Ishibashi <​bashi@chromium.org>

Reviewed by Andreas Kling.

css style="max-width:none" works wrong
​https://bugs.webkit.org/show_bug.cgi?id=53743

Fix a bug that "max-width:none" works wrong.
See also: ​http://trac.webkit.org/changeset/13462

Test: fast/css/max-width-none.html

• css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): For max-width of none, set it to Length(undefinedLength, Fixed), which is the correct value.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/max-width-none-expected.txt (added)
• LayoutTests/fast/css/max-width-none.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/CSSStyleSelector.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-02-14  Kenichi Ishibashi  <bashi@chromium.org>
+
+        Reviewed by Andreas Kling.
+
+        css style="max-width:none" works wrong
+        https://bugs.webkit.org/show_bug.cgi?id=53743
+
+        Adds a test to ensure style 'max-width: none' works correctly.
+
+        * fast/css/max-width-none-expected.txt: Added.
+        * fast/css/max-width-none.html: Added.
+
 2011-02-14  Pavel Feldman  <pfeldman@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-02-14  Kenichi Ishibashi  <bashi@chromium.org>
+
+        Reviewed by Andreas Kling.
+
+        css style="max-width:none" works wrong
+        https://bugs.webkit.org/show_bug.cgi?id=53743
+
+        Fix a bug that "max-width:none" works wrong.
+        See also: http://trac.webkit.org/changeset/13462
+
+        Test: fast/css/max-width-none.html
+
+        * css/CSSStyleSelector.cpp:
+        (WebCore::CSSStyleSelector::applyProperty): For max-width of none,
+        set it to Length(undefinedLength, Fixed), which is the correct
+        value.
+
 2011-02-14  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/css/CSSStyleSelector.cpp

@@ -4160 +4160 @@
     case CSSPropertyMaxWidth:
         // +none +inherit
-        if (primitiveValue && primitiveValue->getIdent() == CSSValueNone)
+        if (primitiveValue && primitiveValue->getIdent() == CSSValueNone) {
+            l = Length(undefinedLength, Fixed);
             apply = true;
+        }
     case CSSPropertyTop:
     case CSSPropertyLeft: