Changeset 78783 in webkit

Timestamp:

Feb 16, 2011 8:27:04 PM (13 years ago)

Author:

yael.aharon@nokia.com

Message:

2011-02-16 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] Tiles are not created for webkit2 after r77286.
​https://bugs.webkit.org/show_bug.cgi?id=54577

When using the default tile size of 1024x1024, only one tile is created.
Make sure to create this tile by undoing what seems to be a typo in r77286.

• UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::paint): (WebKit::TiledDrawingAreaProxy::createTiles):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/TiledDrawingAreaProxy.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-02-16  Yael Aharon  <yael.aharon@nokia.com>
+
+        Reviewed by Andreas Kling.
+
+        [Qt] Tiles are not created for webkit2 after r77286.
+        https://bugs.webkit.org/show_bug.cgi?id=54577
+
+        When using the default tile size of 1024x1024, only one tile is created.
+        Make sure to create this tile by undoing what seems to be a typo in r77286.
+
+        * UIProcess/TiledDrawingAreaProxy.cpp:
+        (WebKit::TiledDrawingAreaProxy::paint):
+        (WebKit::TiledDrawingAreaProxy::createTiles):
+
 == Rolled over to ChangeLog-2011-02-16 ==

trunk/Source/WebKit2/UIProcess/TiledDrawingAreaProxy.cpp

@@ -342 +342 @@
     TiledDrawingAreaTile::Coordinate bottomRight = tileCoordinateForPoint(IntPoint(dirtyRect.maxX(), dirtyRect.maxY()));
 
-    for (unsigned yCoordinate = topLeft.y(); yCoordinate < bottomRight.y(); ++yCoordinate) {
-        for (unsigned xCoordinate = topLeft.x(); xCoordinate < bottomRight.x(); ++xCoordinate) {
+    for (unsigned yCoordinate = topLeft.y(); yCoordinate <= bottomRight.y(); ++yCoordinate) {
+        for (unsigned xCoordinate = topLeft.x(); xCoordinate <= bottomRight.x(); ++xCoordinate) {
             TiledDrawingAreaTile::Coordinate currentCoordinate(xCoordinate, yCoordinate);
             RefPtr<TiledDrawingAreaTile> currentTile = tileAt(currentCoordinate);
@@ -439 +439 @@
     TiledDrawingAreaTile::Coordinate topLeft = tileCoordinateForPoint(visibleRect.location());
     TiledDrawingAreaTile::Coordinate bottomRight = tileCoordinateForPoint(IntPoint(visibleRect.maxX(), visibleRect.maxY()));
-    for (unsigned yCoordinate = topLeft.y(); yCoordinate < bottomRight.y(); ++yCoordinate) {
-        for (unsigned xCoordinate = topLeft.x(); xCoordinate < bottomRight.x(); ++xCoordinate) {
+    for (unsigned yCoordinate = topLeft.y(); yCoordinate <= bottomRight.y(); ++yCoordinate) {
+        for (unsigned xCoordinate = topLeft.x(); xCoordinate <= bottomRight.x(); ++xCoordinate) {
             TiledDrawingAreaTile::Coordinate currentCoordinate(xCoordinate, yCoordinate);
             // Distance is 0 for all currently visible tiles.