Changeset 78842 in webkit


Ignore:
Timestamp:
Feb 17, 2011 10:04:52 AM (13 years ago)
Author:
luiz@webkit.org
Message:

HTML5 <details> and <summary>: localized text
​https://bugs.webkit.org/show_bug.cgi?id=54260

Reviewed by Adam Roben.

Source/WebCore:

The method defaultDetailsSummaryText was added to LocalizationStrategy class and to
platform/LocalizedStrings. It is used to provide the default label to be used by a
<details> tag that has no <summary> child.

  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp:

(WebCore::fileButtonNoFileSelectedLabel):
(WebCore::defaultDetailsSummaryText):

  • platform/LocalizedStrings.h:
  • platform/android/LocalizedStringsAndroid.cpp:

(WebCore::defaultDetailsSummaryText):

  • platform/brew/LocalizedStringsBrew.cpp:

(WebCore::defaultDetailsSummaryText):

  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::defaultDetailsSummaryText):

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::defaultDetailsSummaryText):

  • platform/haiku/LocalizedStringsHaiku.cpp:

(WebCore::defaultDetailsSummaryText):

  • platform/wx/LocalizedStringsWx.cpp:

(WebCore::defaultDetailsSummaryText):

Source/WebKit:

Default details summary text must be localizable.

  • English.lproj/Localizable.strings:

Source/WebKit/chromium:

The method defaultDetailsSummaryText was added to LocalizedStrings. It is used to provide
the default label to be used by a <details> tag that has no <summary> child.

  • src/LocalizedStrings.cpp:

(WebCore::defaultDetailsSummaryText):

Source/WebKit/mac:

The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
provide the default label to be used by a <details> tag that has no <summary> child.

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::defaultDetailsSummaryText):

Source/WebKit/qt:

The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
provide the default label to be used by a <details> tag that has no <summary> child.

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::defaultDetailsSummaryText):

  • WebCoreSupport/WebPlatformStrategies.h:

Source/WebKit/win:

The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
provide the default label to be used by a <details> tag that has no <summary> child.

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::defaultDetailsSummaryText):

  • WebCoreSupport/WebPlatformStrategies.h:

Source/WebKit/wince:

The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
provide the default label to be used by a <details> tag that has no <summary> child.

  • WebCoreSupport/PlatformStrategiesWinCE.cpp:

(PlatformStrategiesWinCE::defaultDetailsSummaryText):

  • WebCoreSupport/PlatformStrategiesWinCE.h:

Source/WebKit2:

The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
provide the default label to be used by a <details> tag that has no <summary> child.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::defaultDetailsSummaryText):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
Location:
trunk/Source
Files:
29 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r78834 r78842  
     12011-02-10  Luiz Agostini  <luiz.agostini@openbossa.org>
     2
     3        Reviewed by Adam Roben.
     4
     5        HTML5 <details> and <summary>: localized text
     6        https://bugs.webkit.org/show_bug.cgi?id=54260
     7
     8        The method defaultDetailsSummaryText was added to LocalizationStrategy class and to
     9        platform/LocalizedStrings. It is used to provide the default label to be used by a
     10        <details> tag that has no <summary> child.
     11
     12        * platform/LocalizationStrategy.h:
     13        * platform/LocalizedStrings.cpp:
     14        (WebCore::fileButtonNoFileSelectedLabel):
     15        (WebCore::defaultDetailsSummaryText):
     16        * platform/LocalizedStrings.h:
     17        * platform/android/LocalizedStringsAndroid.cpp:
     18        (WebCore::defaultDetailsSummaryText):
     19        * platform/brew/LocalizedStringsBrew.cpp:
     20        (WebCore::defaultDetailsSummaryText):
     21        * platform/efl/LocalizedStringsEfl.cpp:
     22        (WebCore::defaultDetailsSummaryText):
     23        * platform/gtk/LocalizedStringsGtk.cpp:
     24        (WebCore::defaultDetailsSummaryText):
     25        * platform/haiku/LocalizedStringsHaiku.cpp:
     26        (WebCore::defaultDetailsSummaryText):
     27        * platform/wx/LocalizedStringsWx.cpp:
     28        (WebCore::defaultDetailsSummaryText):
     29
    1302011-02-17  Kristian Amlie  <kristian.amlie@nokia.com>
    231

  • trunk/Source/WebCore/platform/LocalizationStrategy.h

    r77892 r78842  
    4444    virtual String fileButtonChooseFileLabel() = 0;
    4545    virtual String fileButtonNoFileSelectedLabel() = 0;
     46    virtual String defaultDetailsSummaryText() = 0;
    4647
    4748#if PLATFORM(MAC)

  • trunk/Source/WebCore/platform/LocalizedStrings.cpp

    r77892 r78842  
    6767}
    6868
     69String defaultDetailsSummaryText()
     70{
     71    return platformStrategies()->localizationStrategy()->defaultDetailsSummaryText();
     72}
     73
    6974#if PLATFORM(MAC)
    7075String copyImageUnknownFileLabel()

  • trunk/Source/WebCore/platform/LocalizedStrings.h

    r77892 r78842  
    4040    String fileButtonChooseFileLabel();
    4141    String fileButtonNoFileSelectedLabel();
     42    String defaultDetailsSummaryText();
    4243
    4344#if PLATFORM(MAC)

  • trunk/Source/WebCore/platform/android/LocalizedStringsAndroid.cpp

    r72363 r78842  
    369369}
    370370
     371String defaultDetailsSummaryText()
     372{
     373    return String("Details");
     374}
     375
    371376String submitButtonDefaultLabel()
    372377{

  • trunk/Source/WebCore/platform/brew/LocalizedStringsBrew.cpp

    r72363 r78842  
    4747}
    4848
     49String defaultDetailsSummaryText()
     50{
     51    return "Details";
     52}
     53
    4954String searchableIndexIntroduction()
    5055{

  • trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp

    r72363 r78842  
    5454}
    5555
     56String defaultDetailsSummaryText()
     57{
     58    return String::fromUTF8("Details");
     59}
     60
    5661String searchableIndexIntroduction()
    5762{

  • trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp

    r72363 r78842  
    6565{
    6666    return String::fromUTF8(_("Reset"));
     67}
     68
     69String defaultDetailsSummaryText()
     70{
     71    return String::fromUTF8(_("Details"));
    6772}
    6873

  • trunk/Source/WebCore/platform/haiku/LocalizedStringsHaiku.cpp

    r72363 r78842  
    4949}
    5050
     51String defaultDetailsSummaryText()
     52{
     53    return "Details";
     54}
     55
    5156String defaultLanguage()
    5257{

  • trunk/Source/WebCore/platform/wx/LocalizedStringsWx.cpp

    r73051 r78842  
    4848}
    4949
     50String defaultDetailsSummaryText()
     51{
     52    return String("Details");
     53}
     54
    5055String platformDefaultLanguage()
    5156{

  • trunk/Source/WebKit/ChangeLog

    r77771 r78842  
     12011-02-16  Luiz Agostini  <luiz.agostini@openbossa.org>
     2
     3        Reviewed by Adam Roben.
     4
     5        HTML5 <details> and <summary>: localized text
     6        https://bugs.webkit.org/show_bug.cgi?id=54260
     7
     8        Default details summary text must be localizable.
     9
     10        * English.lproj/Localizable.strings:
     11
    1122011-02-06  Patrick Gansterer  <paroga@webkit.org>
    213

  • trunk/Source/WebKit/English.lproj/Localizable.strings

    r71353 r78842  
    113113"Default" = "Default";
    114114
     115/* text to display in <details> tag when it has no <summary> child */
     116"Details" = "Details";
     117
    115118/* Download Image context menu item */
    116119"Download Image" = "Download Image";

  • trunk/Source/WebKit/chromium/ChangeLog

    r78838 r78842  
     12011-02-10  Luiz Agostini  <luiz.agostini@openbossa.org>
     2
     3        Reviewed by Adam Roben.
     4
     5        HTML5 <details> and <summary>: localized text
     6        https://bugs.webkit.org/show_bug.cgi?id=54260
     7
     8        The method defaultDetailsSummaryText was added to LocalizedStrings. It is used to provide
     9        the default label to be used by a <details> tag that has no <summary> child.
     10
     11        * src/LocalizedStrings.cpp:
     12        (WebCore::defaultDetailsSummaryText):
     13
    1142011-02-17  Steve Lacey  <sjl@chromium.org>
    215

  • trunk/Source/WebKit/chromium/src/LocalizedStrings.cpp

    r72844 r78842  
    8686{
    8787    return query(WebLocalizedString::FileButtonChooseFileLabel);
     88}
     89
     90String defaultDetailsSummaryText()
     91{
     92    notImplemented();
     93    return String("Details");
    8894}
    8995

  • trunk/Source/WebKit/mac/ChangeLog

    r78788 r78842  
     12011-02-10  Luiz Agostini  <luiz.agostini@openbossa.org>
     2
     3        Reviewed by Adam Roben.
     4
     5        HTML5 <details> and <summary>: localized text
     6        https://bugs.webkit.org/show_bug.cgi?id=54260
     7
     8        The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
     9        provide the default label to be used by a <details> tag that has no <summary> child.
     10
     11        * WebCoreSupport/WebPlatformStrategies.h:
     12        * WebCoreSupport/WebPlatformStrategies.mm:
     13        (WebPlatformStrategies::defaultDetailsSummaryText):
     14
    1152011-02-16  Matthew Delaney  <mdelaney@apple.com>
    216

  • trunk/Source/WebKit/mac/WebCoreSupport/WebPlatformStrategies.h

    r68038 r78842  
    5656    virtual WTF::String fileButtonNoFileSelectedLabel();
    5757    virtual WTF::String copyImageUnknownFileLabel();
     58    virtual WTF::String defaultDetailsSummaryText();
    5859#if ENABLE(CONTEXT_MENUS)
    5960    virtual WTF::String contextMenuItemTagOpenLinkInNewWindow();

  • trunk/Source/WebKit/mac/WebCoreSupport/WebPlatformStrategies.mm

    r71353 r78842  
    108108{
    109109    return UI_STRING("Submit", "default label for Submit buttons in forms on web pages");
     110}
     111
     112String WebPlatformStrategies::defaultDetailsSummaryText()
     113{
     114    return UI_STRING("Details", "text to display in <details> tag when it has no <summary> child");
    110115}
    111116

  • trunk/Source/WebKit/qt/ChangeLog

    r78817 r78842  
     12011-02-10  Luiz Agostini  <luiz.agostini@openbossa.org>
     2
     3        Reviewed by Adam Roben.
     4
     5        HTML5 <details> and <summary>: localized text
     6        https://bugs.webkit.org/show_bug.cgi?id=54260
     7
     8        The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
     9        provide the default label to be used by a <details> tag that has no <summary> child.
     10
     11        * WebCoreSupport/WebPlatformStrategies.cpp:
     12        (WebPlatformStrategies::defaultDetailsSummaryText):
     13        * WebCoreSupport/WebPlatformStrategies.h:
     14
    1152011-02-17  Hui Huang  <hui.2.huang@nokia.com>
    216

  • trunk/Source/WebKit/qt/WebCoreSupport/WebPlatformStrategies.cpp

    r77892 r78842  
    169169{
    170170    return QCoreApplication::translate("QWebPage", "No file selected", "text to display in file button used in HTML forms when no file is selected");
     171}
     172
     173String WebPlatformStrategies::defaultDetailsSummaryText()
     174{
     175    return QCoreApplication::translate("QWebPage", "Details", "text to display in <details> tag when it has no <summary> child");
    171176}
    172177

  • trunk/Source/WebKit/qt/WebCoreSupport/WebPlatformStrategies.h

    r77892 r78842  
    6161    virtual WTF::String fileButtonChooseFileLabel();
    6262    virtual WTF::String fileButtonNoFileSelectedLabel();
     63    virtual WTF::String defaultDetailsSummaryText();
    6364    virtual WTF::String contextMenuItemTagOpenLinkInNewWindow();
    6465    virtual WTF::String contextMenuItemTagDownloadLinkToDisk();

  • trunk/Source/WebKit/win/ChangeLog

    r78789 r78842  
     12011-02-10  Luiz Agostini  <luiz.agostini@openbossa.org>
     2
     3        Reviewed by Adam Roben.
     4
     5        HTML5 <details> and <summary>: localized text
     6        https://bugs.webkit.org/show_bug.cgi?id=54260
     7
     8        The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
     9        provide the default label to be used by a <details> tag that has no <summary> child.
     10
     11        * WebCoreSupport/WebPlatformStrategies.cpp:
     12        (WebPlatformStrategies::defaultDetailsSummaryText):
     13        * WebCoreSupport/WebPlatformStrategies.h:
     14
    1152011-02-16  Dominic Mazzoni  <dmazzoni@google.com>
    216

  • trunk/Source/WebKit/win/WebCoreSupport/WebPlatformStrategies.cpp

    r68038 r78842  
    132132{
    133133    return UI_STRING("no file selected", "text to display in file button used in HTML forms when no file is selected");
     134}
     135
     136String WebPlatformStrategies::defaultDetailsSummaryText()
     137{
     138    return UI_STRING("Details", "text to display in <details> tag when it has no <summary> child");
    134139}
    135140

  • trunk/Source/WebKit/win/WebCoreSupport/WebPlatformStrategies.h

    r68038 r78842  
    5555    virtual WTF::String fileButtonChooseFileLabel();
    5656    virtual WTF::String fileButtonNoFileSelectedLabel();
     57    virtual WTF::String defaultDetailsSummaryText();
    5758#if ENABLE(CONTEXT_MENUS)
    5859    virtual WTF::String contextMenuItemTagOpenLinkInNewWindow();

  • trunk/Source/WebKit/wince/ChangeLog

    r78533 r78842  
     12011-02-10  Luiz Agostini  <luiz.agostini@openbossa.org>
     2
     3        Reviewed by Adam Roben.
     4
     5        HTML5 <details> and <summary>: localized text
     6        https://bugs.webkit.org/show_bug.cgi?id=54260
     7
     8        The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
     9        provide the default label to be used by a <details> tag that has no <summary> child.
     10
     11        * WebCoreSupport/PlatformStrategiesWinCE.cpp:
     12        (PlatformStrategiesWinCE::defaultDetailsSummaryText):
     13        * WebCoreSupport/PlatformStrategiesWinCE.h:
     14
    1152011-01-26  MORITA Hajime  <morrita@google.com>
    216

  • trunk/Source/WebKit/wince/WebCoreSupport/PlatformStrategiesWinCE.cpp

    r69850 r78842  
    136136{
    137137    return UI_STRING("no file selected", "text to display in file button used in HTML forms when no file is selected");
     138}
     139
     140String PlatformStrategiesWinCE::defaultDetailsSummaryText()
     141{
     142    return UI_STRING("Details", "text to display in <details> tag when it has no <summary> child");
    138143}
    139144

  • trunk/Source/WebKit/wince/WebCoreSupport/PlatformStrategiesWinCE.h

    r68172 r78842  
    5454    virtual WTF::String fileButtonChooseFileLabel();
    5555    virtual WTF::String fileButtonNoFileSelectedLabel();
     56    virtual WTF::String defaultDetailsSummaryText();
    5657#if ENABLE(CONTEXT_MENUS)
    5758    virtual WTF::String contextMenuItemTagOpenLinkInNewWindow();

  • trunk/Source/WebKit2/ChangeLog

    r78832 r78842  
     12011-02-10  Luiz Agostini  <luiz.agostini@openbossa.org>
     2
     3        Reviewed by Adam Roben.
     4
     5        HTML5 <details> and <summary>: localized text
     6        https://bugs.webkit.org/show_bug.cgi?id=54260
     7
     8        The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
     9        provide the default label to be used by a <details> tag that has no <summary> child.
     10
     11        * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
     12        (WebKit::WebPlatformStrategies::defaultDetailsSummaryText):
     13        * WebProcess/WebCoreSupport/WebPlatformStrategies.h:
     14
    1152011-02-17  Adam Roben  <aroben@apple.com>
    216

  • trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp

    r77892 r78842  
    174174{
    175175    return UI_STRING("no file selected", "text to display in file button used in HTML forms when no file is selected");
     176}
     177
     178String WebPlatformStrategies::defaultDetailsSummaryText()
     179{
     180    return UI_STRING("Details", "text to display in <details> tag when it has no <summary> child");
    176181}
    177182

  • trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h

    r77892 r78842  
    5959    virtual String fileButtonChooseFileLabel();
    6060    virtual String fileButtonNoFileSelectedLabel();
     61    virtual String defaultDetailsSummaryText();
    6162#if PLATFORM(MAC)
    6263    virtual String copyImageUnknownFileLabel();
Note: See TracChangeset for help on using the changeset viewer.