Changeset 78949 in webkit

Timestamp:

Feb 17, 2011 8:43:08 PM (13 years ago)

Author:

dpranke@chromium.org

Message:

2011-02-17 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Roben.

Add blacklist of remaining webkitpy/* modules that fail on
Win32, so that test-webkitpy will at least run cleanly.

​https://bugs.webkit.org/show_bug.cgi?id=54709

• Scripts/webkitpy/layout_tests/test/main.py:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/test/main.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-02-17  Dirk Pranke  <dpranke@chromium.org>
+
+        Reviewed by Adam Roben.
+
+        Add blacklist of remaining webkitpy/* modules that fail on
+        Win32, so that test-webkitpy will at least run cleanly.
+
+        https://bugs.webkit.org/show_bug.cgi?id=54709
+
+        * Scripts/webkitpy/layout_tests/test/main.py:
+
 2011-02-17  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Tools/Scripts/webkitpy/test/main.py

@@ -80 +80 @@
         return modules
 
+    def _win32_blacklist(self, module_path):
+        # FIXME: Remove this once https://bugs.webkit.org/show_bug.cgi?id=54526 is resolved.
+        if any([module_path.startswith(package) for package in [
+            'webkitpy.tool',
+            'webkitpy.style',
+            'webkitpy.common.net',
+            'webkitpy.common.checkout',
+            'webkitpy.common.config',
+            ]]):
+            return False
+
+        return module_path not in [
+            # FIXME: Remove this when https://bugs.webkit.org/show_bug.cgi?id=54525 is resolved.
+            'webkitpy.common.net.testoutputset_unittest',
+
+            # FIXME: This file also requires common.checkout to work
+            'webkitpy.layout_tests.deduplicate_tests_unittest',
+
+            'webkitpy.common.prettypatch_unittest',
+            'webkitpy.layout_tests.update_webgl_conformance_tests_unittest',
+            'webkitpy.layout_tests.port.mac_unittest',
+            'webkitpy.layout_tests.port.chromium_unittest',
+            'webkitpy.layout_tests.port.mock_drt_unittest',
+            'webkitpy.layout_tests.port.config_unittest',
+        ]
+
     def run_tests(self, sys_argv, external_package_paths=None):
         """Run the unit tests in all *_unittest.py modules in webkitpy.
@@ -131 +157 @@
             modules.remove(excluded_module)
 
+        if sys.platform == 'win32':
+            modules = filter(self._win32_blacklist, modules)
+
         sys_argv.extend(modules)