Changeset 79085 in webkit

Timestamp:

Feb 18, 2011 7:58:37 PM (13 years ago)

Author:

yi.4.shen@nokia.com

Message:

2011-02-18 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Tor Arne Vestbø.

Always display the media controls when requiresFullscreenForVideoPlayback() is true
​https://bugs.webkit.org/show_bug.cgi?id=54308

For video element, it should have controls when
Chrome::requiresFullscreenForVideoPlayback() is true.

• html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::controls):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLMediaElement.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-02-18  Yi Shen  <yi.4.shen@nokia.com>
+
+        Reviewed by Tor Arne Vestbø.
+
+        Always display the media controls when requiresFullscreenForVideoPlayback() is true
+        https://bugs.webkit.org/show_bug.cgi?id=54308
+
+        For video element, it should have controls when 
+        Chrome::requiresFullscreenForVideoPlayback() is true.
+
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::controls):
+
 2011-02-18  Adrienne Walker  <enne@google.com>
 

trunk/Source/WebCore/html/HTMLMediaElement.cpp

@@ -1471 +1471 @@
         return true;
 
+    // always show controls for video when fullscreen playback is required.
+    if (isVideo() && document()->page() && document()->page()->chrome()->requiresFullscreenForVideoPlayback())
+        return true;
+
     return hasAttribute(controlsAttr);
 }