Changeset 79093 in webkit

Timestamp:

Feb 18, 2011 9:43:18 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-02-18 Jonathan Backer <​backer@chromium.org>

Reviewed by Eric Seidel.

[chromium] Fix leak of texture IDs in compositor.
​https://bugs.webkit.org/show_bug.cgi?id=54750

No new tests. It is extremely unlikely that this leak would have
any user visible impact because only a few bytes of space are wasted
(we're leaking texture IDs, not actual textures) and the space of
texture IDs is large (32 bits).

• platform/graphics/chromium/TextureManager.cpp: (WebCore::TextureManager::requestTexture):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/chromium/TextureManager.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-02-18  Jonathan Backer  <backer@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        [chromium] Fix leak of texture IDs in compositor.
+        https://bugs.webkit.org/show_bug.cgi?id=54750
+
+        No new tests. It is extremely unlikely that this leak would have
+        any user visible impact because only a few bytes of space are wasted
+        (we're leaking texture IDs, not actual textures) and the space of
+        texture IDs is large (32 bits).
+
+       * platform/graphics/chromium/TextureManager.cpp:
+        (WebCore::TextureManager::requestTexture):
+
 2011-02-18  Yi Shen  <yi.4.shen@nokia.com>
 

trunk/Source/WebCore/platform/graphics/chromium/TextureManager.cpp

@@ -153 +153 @@
         return 0;
 
-    unsigned textureId = m_context->createTexture();
+    unsigned textureId;
     GLC(m_context.get(), textureId = m_context->createTexture());
     GLC(m_context.get(), m_context->bindTexture(GraphicsContext3D::TEXTURE_2D, textureId));