Changeset 79695 in webkit

Timestamp:

Feb 25, 2011 10:45:10 AM (13 years ago)

Author:

Adam Roben

Message:

Work around Cygwin's crash-suppression behavior

Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which any processes it launches will
inherit. This is bad for testing/debugging, as it causes the post-mortem debugger not to be
invoked. (Cygwin does this because it makes crashes more UNIX-y.) We reset the error mode
when our test apps launch to work around Cygwin's behavior.

Fixes <​http://webkit.org/b/55222> Test apps crash silently (without invoking post-mortem
debugger) when launched from Cygwin 1.7

Reviewed by Darin Adler.

Source/JavaScriptCore:

• API/tests/testapi.c: Added a now-needed #include.

(main):

• jsc.cpp:

(main):
Call ::SetErrorMode(0) to undo Cygwin's folly.

• JavaScriptCore.vcproj/testapi/testapiCommon.vsprops: Define NOMINMAX like many of our

other projects do so that windows.h won't define min/max macros that interfere with
std::numeric_limits<T>::min/max.

Tools:

• DumpRenderTree/win/DumpRenderTree.cpp:

(main):

• TestWebKitAPI/win/main.cpp:

(main):

• WebKitAPITest/main.cpp:

(main):

• WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::platformInitialize):
Call ::SetErrorMode(0) to undo Cygwin's folly.

Location:

trunk

Files:

• Source/JavaScriptCore/API/tests/testapi.c (modified) (2 diffs)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/JavaScriptCore.vcproj/testapi/testapiCommon.vsprops (modified) (1 diff)
• Source/JavaScriptCore/jsc.cpp (modified) (2 diffs)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/win/DumpRenderTree.cpp (modified) (1 diff)
• Tools/TestWebKitAPI/win/main.cpp (modified) (1 diff)
• Tools/WebKitAPITest/main.cpp (modified) (1 diff)
• Tools/WebKitTestRunner/win/TestControllerWin.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/API/tests/testapi.c

@@ -33 +33 @@
 #include <wtf/UnusedParam.h>
 
+#if OS(WINDOWS)
+#include <windows.h>
+#endif
+
 #if COMPILER(MSVC)
 
@@ -820 +824 @@
 int main(int argc, char* argv[])
 {
+#if OS(WINDOWS)
+    // Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which we will inherit. This is bad for
+    // testing/debugging, as it causes the post-mortem debugger not to be invoked. We reset the
+    // error mode here to work around Cygwin's behavior. See <http://webkit.org/b/55222>.
+    ::SetErrorMode(0);
+#endif
+
     const char *scriptPath = "testapi.js";
     if (argc > 1) {

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2011-02-25  Adam Roben  <aroben@apple.com>
+
+        Work around Cygwin's crash-suppression behavior
+
+        Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which any processes it launches will
+        inherit. This is bad for testing/debugging, as it causes the post-mortem debugger not to be
+        invoked. (Cygwin does this because it makes crashes more UNIX-y.) We reset the error mode
+        when our test apps launch to work around Cygwin's behavior.
+
+        Fixes <http://webkit.org/b/55222> Test apps crash silently (without invoking post-mortem
+        debugger) when launched from Cygwin 1.7
+
+        Reviewed by Darin Adler.
+
+        * API/tests/testapi.c: Added a now-needed #include.
+        (main):
+        * jsc.cpp:
+        (main):
+        Call ::SetErrorMode(0) to undo Cygwin's folly.
+
+        * JavaScriptCore.vcproj/testapi/testapiCommon.vsprops: Define NOMINMAX like many of our
+        other projects do so that windows.h won't define min/max macros that interfere with
+        std::numeric_limits<T>::min/max.
+
 2011-02-24  Adam Barth  <abarth@webkit.org>
 

trunk/Source/JavaScriptCore/JavaScriptCore.vcproj/testapi/testapiCommon.vsprops

@@ -8 +8 @@
                 Name="VCCLCompilerTool"
                 AdditionalIncludeDirectories=""$(ProjectDir)\..\..\API";"$(ConfigurationBuildDir)\include\WebCore\ForwardingHeaders";"$(ConfigurationBuildDir)\include\JavaScriptCore";"$(ConfigurationBuildDir)\include\private\JavaScriptCore";"$(ConfigurationBuildDir)\include";"$(ConfigurationBuildDir)\include\private";"$(WebKitLibrariesDir)\include";"$(WebKitLibrariesDir)\include\private""
+                PreprocessorDefinitions="NOMINMAX"
                 WarningLevel="4"
                 Detect64BitPortabilityProblems="true"

trunk/Source/JavaScriptCore/jsc.cpp

@@ -325 +325 @@
 int main(int argc, char** argv)
 {
-#if defined(_DEBUG) && OS(WINDOWS)
+#if OS(WINDOWS)
+    // Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which we will inherit. This is bad for
+    // testing/debugging, as it causes the post-mortem debugger not to be invoked. We reset the
+    // error mode here to work around Cygwin's behavior. See <http://webkit.org/b/55222>.
+    ::SetErrorMode(0);
+
+#if defined(_DEBUG)
     _CrtSetReportFile(_CRT_WARN, _CRTDBG_FILE_STDERR);
     _CrtSetReportMode(_CRT_WARN, _CRTDBG_MODE_FILE);
@@ -332 +338 @@
     _CrtSetReportFile(_CRT_ASSERT, _CRTDBG_FILE_STDERR);
     _CrtSetReportMode(_CRT_ASSERT, _CRTDBG_MODE_FILE);
+#endif
 #endif
 

trunk/Tools/ChangeLog

@@ +1 @@
+2011-02-25  Adam Roben  <aroben@apple.com>
+
+        Work around Cygwin's crash-suppression behavior
+
+        Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which any processes it launches will
+        inherit. This is bad for testing/debugging, as it causes the post-mortem debugger not to be
+        invoked. (Cygwin does this because it makes crashes more UNIX-y.) We reset the error mode
+        when our test apps launch to work around Cygwin's behavior.
+
+        Fixes <http://webkit.org/b/55222> Test apps crash silently (without invoking post-mortem
+        debugger) when launched from Cygwin 1.7
+
+        Reviewed by Darin Adler.
+
+        * DumpRenderTree/win/DumpRenderTree.cpp:
+        (main):
+        * TestWebKitAPI/win/main.cpp:
+        (main):
+        * WebKitAPITest/main.cpp:
+        (main):
+        * WebKitTestRunner/win/TestControllerWin.cpp:
+        (WTR::TestController::platformInitialize):
+        Call ::SetErrorMode(0) to undo Cygwin's folly.
+
 2011-02-24  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
 

trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp

@@ -1259 +1259 @@
 int main(int argc, char* argv[])
 {
+    // Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which we will inherit. This is bad for
+    // testing/debugging, as it causes the post-mortem debugger not to be invoked. We reset the
+    // error mode here to work around Cygwin's behavior. See <http://webkit.org/b/55222>.
+    ::SetErrorMode(0);
+
     ::SetUnhandledExceptionFilter(exceptionFilter);
 

trunk/Tools/TestWebKitAPI/win/main.cpp

@@ -28 +28 @@
 int main(int argc, const char* argv[])
 {
+    // Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which we will inherit. This is bad for
+    // testing/debugging, as it causes the post-mortem debugger not to be invoked. We reset the
+    // error mode here to work around Cygwin's behavior. See <http://webkit.org/b/55222>.
+    ::SetErrorMode(0);
+
     bool passed = true;
 

trunk/Tools/WebKitAPITest/main.cpp

@@ -29 +29 @@
 int main(int, char*[])
 {
+    // Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which we will inherit. This is bad for
+    // testing/debugging, as it causes the post-mortem debugger not to be invoked. We reset the
+    // error mode here to work around Cygwin's behavior. See <http://webkit.org/b/55222>.
+    ::SetErrorMode(0);
+
     // FIXME: Remove this line once <http://webkit.org/b/32867> is fixed.
     OleInitialize(0);

trunk/Tools/WebKitTestRunner/win/TestControllerWin.cpp

@@ -97 +97 @@
 void TestController::platformInitialize()
 {
+    // Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which we will inherit. This is bad for
+    // testing/debugging, as it causes the post-mortem debugger not to be invoked. We reset the
+    // error mode here to work around Cygwin's behavior. See <http://webkit.org/b/55222>.
+    ::SetErrorMode(0);
+
     ::SetUnhandledExceptionFilter(exceptionFilter);