Changeset 79768 in webkit
- Timestamp:
- Feb 26, 2011 1:03:34 AM (13 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r79766 r79768 1 2011-02-26 Yi Shen <yi.4.shen@nokia.com> 2 3 Reviewed by Eric Carlson. 4 5 Missing volumechangeEvent in case of mediaPlayerVolumeChanged gets callback 6 https://bugs.webkit.org/show_bug.cgi?id=55147 7 8 When HTMLMediaElement::mediaPlayerVolumeChanged() gets callback, 9 a volumechangeEvent event should be fired if the volume gets changed. 10 11 Test: media/event-attributes.html 12 13 * html/HTMLMediaElement.cpp: 14 (WebCore::HTMLMediaElement::setMuted): Remove updateVolume() since it does nothing when m_player is 0. 15 (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): Fire a volumechangeEvent when the volume is changed. 16 1 17 2011-02-26 Eric Seidel <eric@webkit.org> 2 18 -
trunk/Source/WebCore/html/HTMLMediaElement.cpp
r79744 r79768 1522 1522 if (renderer()) 1523 1523 renderer()->updateFromElement(); 1524 } else 1525 updateVolume(); 1524 } 1526 1525 } 1527 1526 scheduleEvent(eventNames().volumechangeEvent); … … 1863 1862 1864 1863 beginProcessingMediaPlayerCallback(); 1865 if (m_player) 1866 m_volume = m_player->volume(); 1867 updateVolume(); 1864 if (m_player) { 1865 float vol = m_player->volume(); 1866 if (vol != m_volume) { 1867 m_volume = vol; 1868 updateVolume(); 1869 scheduleEvent(eventNames().volumechangeEvent); 1870 } 1871 } 1868 1872 endProcessingMediaPlayerCallback(); 1869 1873 }
Note: See TracChangeset
for help on using the changeset viewer.