Changeset 79782 in webkit


Ignore:
Timestamp:
Feb 26, 2011 6:26:03 AM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-02-26 Bill Budge <bbudge@chromium.org>

Reviewed by David Levin.

WebURLRequest, WebURLResponse properties should be passed to WebCore Layer
https://bugs.webkit.org/show_bug.cgi?id=54489

No tests needed. This is already tested by ui_tests, nacl_ui_tests, and nacl_sandbox_tests

  • src/WebURLRequest.cpp: (WebKit::WebURLRequestPrivateImpl::WebURLRequestPrivateImpl): (WebKit::WebURLRequest::downloadToFile): (WebKit::WebURLRequest::setDownloadToFile):
  • src/WebURLRequestPrivate.h: (WebKit::WebURLRequestPrivate::WebURLRequestPrivate):
  • src/WebURLResponse.cpp: (WebKit::WebURLResponsePrivateImpl::WebURLResponsePrivateImpl): (WebKit::WebURLResponse::downloadFilePath): (WebKit::WebURLResponse::setDownloadFilePath):
  • src/WebURLResponsePrivate.h:
Location:
trunk/Source/WebKit/chromium
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/chromium/ChangeLog

    r79779 r79782  
     12011-02-26  Bill Budge  <bbudge@chromium.org>
     2
     3        Reviewed by David Levin.
     4
     5        WebURLRequest, WebURLResponse properties should be passed to WebCore Layer
     6        https://bugs.webkit.org/show_bug.cgi?id=54489
     7
     8        No tests needed. This is already tested by ui_tests, nacl_ui_tests, and nacl_sandbox_tests
     9
     10        * src/WebURLRequest.cpp:
     11        (WebKit::WebURLRequestPrivateImpl::WebURLRequestPrivateImpl):
     12        (WebKit::WebURLRequest::downloadToFile):
     13        (WebKit::WebURLRequest::setDownloadToFile):
     14        * src/WebURLRequestPrivate.h:
     15        (WebKit::WebURLRequestPrivate::WebURLRequestPrivate):
     16        * src/WebURLResponse.cpp:
     17        (WebKit::WebURLResponsePrivateImpl::WebURLResponsePrivateImpl):
     18        (WebKit::WebURLResponse::downloadFilePath):
     19        (WebKit::WebURLResponse::setDownloadFilePath):
     20        * src/WebURLResponsePrivate.h:
     21
    1222011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
    223
  • trunk/Source/WebKit/chromium/src/WebURLRequest.cpp

    r78705 r79782  
    5757        m_resourceRequest = &m_resourceRequestAllocation;
    5858        m_allowStoredCredentials = p->m_allowStoredCredentials;
    59         m_downloadToFile = p->m_downloadToFile;
    6059    }
    6160
     
    270269bool WebURLRequest::downloadToFile() const
    271270{
    272     return m_private->m_downloadToFile;
     271    return m_private->m_resourceRequest->downloadToFile();
    273272}
    274273
    275274void WebURLRequest::setDownloadToFile(bool downloadToFile)
    276275{
    277     m_private->m_downloadToFile = downloadToFile;
     276    m_private->m_resourceRequest->setDownloadToFile(downloadToFile);
    278277}
    279278
  • trunk/Source/WebKit/chromium/src/WebURLRequestPrivate.h

    r78705 r79782  
    4040    WebURLRequestPrivate()
    4141        : m_resourceRequest(0)
    42         , m_allowStoredCredentials(true)
    43         , m_downloadToFile(false) { }
     42        , m_allowStoredCredentials(true) { }
    4443
    4544    // Called by WebURLRequest when it no longer needs this object.
     
    4847    WebCore::ResourceRequest* m_resourceRequest;
    4948    bool m_allowStoredCredentials;
    50 
    51     // FIXME: Move this to ResourceRequest once we have an internal consumer.
    52     bool m_downloadToFile;
    5349};
    5450
  • trunk/Source/WebKit/chromium/src/WebURLResponse.cpp

    r78790 r79782  
    6161    {
    6262        m_resourceResponse = &m_resourceResponseAllocation;
    63         m_downloadFilePath = p->m_downloadFilePath;
    6463    }
    6564
     
    377376WebString WebURLResponse::downloadFilePath() const
    378377{
    379     return m_private->m_downloadFilePath;
     378    return m_private->m_resourceResponse->downloadFilePath();
    380379}
    381380
    382381void WebURLResponse::setDownloadFilePath(const WebString& downloadFilePath)
    383382{
    384     m_private->m_downloadFilePath = downloadFilePath;
     383    m_private->m_resourceResponse->setDownloadFilePath(downloadFilePath.utf8().data());
    385384}
    386385
  • trunk/Source/WebKit/chromium/src/WebURLResponsePrivate.h

    r78705 r79782  
    4646
    4747    WebCore::ResourceResponse* m_resourceResponse;
    48 
    49     // FIXME: Move this to ResourceResponse once we have an internal consumer.
    50     WebString m_downloadFilePath;
    5148};
    5249
Note: See TracChangeset for help on using the changeset viewer.