Changeset 79809 in webkit


Ignore:
Timestamp:
Feb 26, 2011 2:38:44 PM (13 years ago)
Author:
yi.4.shen@nokia.com
Message:

2011-02-26 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Notify HTMLMediaElement when MediaPlayerPrivateQt's playback state gets changed
https://bugs.webkit.org/show_bug.cgi?id=55252

Need to invoke a callback function to notify the HTMLMediaElement
when MediaPlayerPrivateQt's playback state gets changed.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt): Set a flag to ignore the playback state change for pre-roll (WebCore::MediaPlayerPrivateQt::commitLoad): Call playbackStateChanged() to notify HTMLMediaElement (WebCore::MediaPlayerPrivateQt::stateChanged):
  • platform/graphics/qt/MediaPlayerPrivateQt.h:
Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r79808 r79809  
     12011-02-26  Yi Shen  <yi.4.shen@nokia.com>
     2
     3        Reviewed by Andreas Kling.
     4
     5        [Qt] Notify HTMLMediaElement when MediaPlayerPrivateQt's playback state gets changed
     6        https://bugs.webkit.org/show_bug.cgi?id=55252
     7
     8        Need to invoke a callback function to notify the HTMLMediaElement
     9        when MediaPlayerPrivateQt's playback state gets changed.
     10
     11        * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
     12        (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt): Set a flag to ignore the playback state change for pre-roll
     13        (WebCore::MediaPlayerPrivateQt::commitLoad): Call playbackStateChanged() to notify HTMLMediaElement
     14        (WebCore::MediaPlayerPrivateQt::stateChanged):
     15        * platform/graphics/qt/MediaPlayerPrivateQt.h:
     16
    1172011-02-25  Abhishek Arya  <inferno@chromium.org>
    218
  • trunk/Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp

    r79668 r79809  
    106106    , m_queuedSeek(-1)
    107107    , m_preload(MediaPlayer::Auto)
     108    , m_suppressNextPlaybackChanged(false)
    108109{
    109110    m_mediaPlayer->setVideoOutput(m_videoItem);
     
    240241    m_mediaPlayer->setVolume(static_cast<int>(element->volume() * 100.0));
    241242
     243    // Don't send PlaybackChanged notification for pre-roll.
     244    m_suppressNextPlaybackChanged = true;
     245
    242246    // Setting a media source will start loading the media, but we need
    243247    // to pre-roll as well to get video size-hints and buffer-status
     
    446450        m_queuedSeek = -1;
    447451    }
     452
     453    if (!m_suppressNextPlaybackChanged)
     454        m_webCorePlayer->playbackStateChanged();
     455    else
     456        m_suppressNextPlaybackChanged = false;
    448457}
    449458
  • trunk/Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.h

    r77207 r79809  
    158158    bool m_delayingLoad;
    159159    String m_mediaUrl;
     160    bool m_suppressNextPlaybackChanged;
    160161
    161162};
Note: See TracChangeset for help on using the changeset viewer.