Changeset 79819 in webkit

Timestamp:

Feb 27, 2011 9:29:35 AM (13 years ago)

Author:

Adam Roben

Message:

Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving

Windows 7 (and maybe Vista?) launches the post-mortem debugger with a working directory that
is different from old-run-webkit-test's. Because of this, the path to the crash log file
(which is relative to $testResultsDirectory) must be an absolute path. See the bug for more
details.

Fixes <​http://webkit.org/b/55318> Crash logs aren't saved on Windows 7 when a relative
--results-directory path is used (like on the test slaves)

Reviewed by Dan Bernstein.

• Scripts/old-run-webkit-tests: Moved the call to setUpWindowsCrashLogSaving after we've

made $testResultsDirectory an absolute path.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/old-run-webkit-tests (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-02-27  Adam Roben  <aroben@apple.com>
+
+        Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving
+
+        Windows 7 (and maybe Vista?) launches the post-mortem debugger with a working directory that
+        is different from old-run-webkit-test's. Because of this, the path to the crash log file
+        (which is relative to $testResultsDirectory) must be an absolute path. See the bug for more
+        details.
+
+        Fixes <http://webkit.org/b/55318> Crash logs aren't saved on Windows 7 when a relative
+        --results-directory path is used (like on the test slaves)
+
+        Reviewed by Dan Bernstein.
+
+        * Scripts/old-run-webkit-tests: Moved the call to setUpWindowsCrashLogSaving after we've
+        made $testResultsDirectory an absolute path.
+
 2011-02-26  Dominic Mazzoni  <dmazzoni@google.com>
 

trunk/Tools/Scripts/old-run-webkit-tests

@@ -404 +404 @@
 $useRemoteLinksToTests = 0 if isGtk();
 
-setUpWindowsCrashLogSaving() if isCygwin();
-
 setConfigurationProductDir(Cwd::abs_path($root)) if (defined($root));
 my $productDir = productDir();
@@ -465 +463 @@
         exit 1;
     }
-}
-
+} elsif (isCygwin()) {
+    setUpWindowsCrashLogSaving();
+}
 
 print "Running tests from $testDirectory\n";