Changeset 79836 in webkit

Timestamp:

Feb 27, 2011 7:39:20 PM (13 years ago)

Author:

ojan@chromium.org

Message:

2011-02-25 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] fix expand links on git diffs
​https://bugs.webkit.org/show_bug.cgi?id=55208

In git diffs, we don't have a "revision" span at the end
of each FileDiff.

• code-review.js:

Location:

trunk/Websites/bugs.webkit.org

Files:

• ChangeLog (modified) (1 diff)
• code-review.js (modified) (1 diff)

trunk/Websites/bugs.webkit.org/ChangeLog

@@ +1 @@
+2011-02-25  Ojan Vafai  <ojan@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        [codereviewtool] fix expand links on git diffs
+        https://bugs.webkit.org/show_bug.cgi?id=55208
+
+        In git diffs, we don't have a "revision" span at the end
+        of each FileDiff.
+        * code-review.js:
+
 2011-02-23  Ojan Vafai  <ojan@chromium.org>
 

trunk/Websites/bugs.webkit.org/code-review.js

@@ -647 +647 @@
     $('br', file_diff).replaceWith(expandBarHtml());
 
+    // jquery doesn't support :last-of-type, so use querySelector instead.
     var last_line = file_diff.querySelector('.LineContainer:last-of-type');
     // Some patches for new files somehow end up with an empty context line at the end
     // with a from line number of 0. Don't show expand links in that case either.
     if (!$(last_line).hasClass('add') && !$(last_line).hasClass('remove') && fromLineNumber(last_line) != 0)
-      $('.revision', file_diff).before(expandBarHtml(ABOVE));
+      $(file_diff.querySelector('.DiffSection:last-of-type')).after(expandBarHtml(ABOVE));
   }