Changeset 79896 in webkit

Timestamp:

Feb 28, 2011 12:25:04 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-02-28 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Alexey Proskuryakov.

Build fix for Intel ICC Compiler.
​https://bugs.webkit.org/show_bug.cgi?id=55221

The virtual inheritance seems to confuse ICC.
Anything that links with webkit has an undefined reference otherwise.

• svg/SVGTransformable.cpp: (WebCore::SVGTransformable::~SVGTransformable):
• svg/SVGTransformable.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• svg/SVGTransformable.cpp (modified) (1 diff)
• svg/SVGTransformable.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Build fix for Intel ICC Compiler.
+        https://bugs.webkit.org/show_bug.cgi?id=55221
+
+        The virtual inheritance seems to confuse ICC.
+        Anything that links with webkit has an undefined reference otherwise.
+
+        * svg/SVGTransformable.cpp:
+        (WebCore::SVGTransformable::~SVGTransformable):
+        * svg/SVGTransformable.h:
+
 2011-02-28  Sergio Villar Senin  <svillar@igalia.com>
 

trunk/Source/WebCore/svg/SVGTransformable.cpp

@@ -90 +90 @@
 static const int optionalValuesForType[] =  {0, 0, 1, 1, 2, 0, 0};
 
+// This destructor is needed in order to link correctly with Intel ICC.
+SVGTransformable::~SVGTransformable()
+{
+}
+
 bool SVGTransformable::parseTransformValue(unsigned type, const UChar*& ptr, const UChar* end, SVGTransform& transform)
 {

trunk/Source/WebCore/svg/SVGTransformable.h

@@ -41 +41 @@
     };
 
+    virtual ~SVGTransformable();
+
     static bool parseTransformAttribute(SVGTransformList&, const AtomicString& transform);
     static bool parseTransformAttribute(SVGTransformList&, const UChar*& ptr, const UChar* end, TransformParsingMode mode = ClearList);