Changeset 79967 in webkit


Ignore:
Timestamp:
Feb 28, 2011 9:12:37 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r79948.
http://trac.webkit.org/changeset/79948
https://bugs.webkit.org/show_bug.cgi?id=55439

"caused crashes on the SL release bot" (Requested by ggaren on
#webkit).

  • runtime/JSGlobalData.h:
  • runtime/WriteBarrier.h:
Location:
trunk/Source/JavaScriptCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r79964 r79967  
     12011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r79948.
     4        http://trac.webkit.org/changeset/79948
     5        https://bugs.webkit.org/show_bug.cgi?id=55439
     6
     7        "caused crashes on the SL release bot" (Requested by ggaren on
     8        #webkit).
     9
     10        * runtime/JSGlobalData.h:
     11        * runtime/WriteBarrier.h:
     12
    1132011-02-28  Gavin Barraclough  <barraclough@apple.com>
    214
  • trunk/Source/JavaScriptCore/runtime/JSGlobalData.h

    r79948 r79967  
    207207        Heap heap;
    208208
    209         GCRootPtr<Unknown> exception;
     209        DeprecatedPtr<Unknown> exception;
    210210#if ENABLE(JIT)
    211211        ReturnAddressPtr exceptionLocation;
  • trunk/Source/JavaScriptCore/runtime/WriteBarrier.h

    r79948 r79967  
    152152};
    153153
    154 template <typename T> class GCRootPtr : public WriteBarrierBase<T> {
    155 public:
    156     GCRootPtr() { }
    157     GCRootPtr(T* value)
    158     {
    159         this->setWithoutWriteBarrier(value);
    160     }
    161 
    162     GCRootPtr& operator=(T* value)
    163     {
    164         this->setWithoutWriteBarrier(value);
    165         return *this;
    166     }
    167 
    168 private:
    169     using WriteBarrier<T>::set;
    170     using WriteBarrier<T>::setWithoutWriteBarrier;
    171 };
    172 
    173 template <> class GCRootPtr<Unknown> : public WriteBarrierBase<Unknown> {
    174 public:
    175     GCRootPtr() { }
    176     GCRootPtr(JSValue value)
    177     {
    178         this->setWithoutWriteBarrier(value);
    179     }
    180    
    181     GCRootPtr& operator=(JSValue value)
    182     {
    183         this->setWithoutWriteBarrier(value);
    184         return *this;
    185     }
    186    
    187 private:
    188     using WriteBarrierBase<Unknown>::set;
    189     using WriteBarrierBase<Unknown>::setWithoutWriteBarrier;
    190 };
    191    
    192154template <typename U, typename V> inline bool operator==(const DeprecatedPtr<U>& lhs, const DeprecatedPtr<V>& rhs)
    193155{
Note: See TracChangeset for help on using the changeset viewer.