Changeset 80024 in webkit

Timestamp:

Mar 1, 2011 12:34:13 PM (13 years ago)

Author:

Adam Roben

Message:

Give WebKitLauncherWin's PDB file a name different from WebKit's

WebKitLauncherWin (which builds WebKit.exe) and WebKit (which builds WebKit.dll) were
fighting over the same PDB file, meaning that one of them was going to lose and not have
symbols. WebKitLauncherWin's PDB file is now named WebKitLauncherWin.pdb.

Fixes <​http://webkit.org/b/55495> Crashes in WebKit.dll have bad backtraces for some test
runs (due to missing symbols)

Reviewed by David Kilzer.

• WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Use the project name,

"WebKitLauncherWin", instead of the target name, "WebKit", when naming the PDB file.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitLauncherWin/WebKitLauncherWinCommon.vsprops (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-03-01  Adam Roben  <aroben@apple.com>
+
+        Give WebKitLauncherWin's PDB file a name different from WebKit's
+
+        WebKitLauncherWin (which builds WebKit.exe) and WebKit (which builds WebKit.dll) were
+        fighting over the same PDB file, meaning that one of them was going to lose and not have
+        symbols. WebKitLauncherWin's PDB file is now named WebKitLauncherWin.pdb.
+
+        Fixes <http://webkit.org/b/55495> Crashes in WebKit.dll have bad backtraces for some test
+        runs (due to missing symbols)
+
+        Reviewed by David Kilzer.
+
+        * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Use the project name,
+        "WebKitLauncherWin", instead of the target name, "WebKit", when naming the PDB file.
+
 2011-03-01  Adam Roben  <aroben@apple.com>
 

trunk/Tools/WebKitLauncherWin/WebKitLauncherWinCommon.vsprops

@@ -9 +9 @@
                 AdditionalDependencies="shlwapi.lib"
                 OutputFile="$(OutDir)\WebKit$(WebKitConfigSuffix).exe"
+                ProgramDatabaseFile="$(TargetDir)$(ProjectName)$(WebKitConfigSuffix).pdb"
         />
 </VisualStudioPropertySheet>