Changeset 80040 in webkit

Timestamp:

Mar 1, 2011 2:18:32 PM (13 years ago)

Author:

inferno@chromium.org

Message:

2011-03-01 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Paint outline for tables.
​https://bugs.webkit.org/show_bug.cgi?id=55474

Test: fast/table/table-and-parts-outline.html

• rendering/RenderTable.cpp: (WebCore::RenderTable::paintObject):

2011-03-01 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we draw outlines for table and table cells.
​https://bugs.webkit.org/show_bug.cgi?id=55474

• fast/table/table-and-parts-outline.html: Added.
• platform/mac/fast/table/table-and-parts-outline-expected.checksum: Added.
• platform/mac/fast/table/table-and-parts-outline-expected.png: Added.
• platform/mac/fast/table/table-and-parts-outline-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/table/table-and-parts-outline.html (added)
• LayoutTests/platform/mac/fast/table/table-and-parts-outline-expected.checksum (added)
• LayoutTests/platform/mac/fast/table/table-and-parts-outline-expected.png (added)
• LayoutTests/platform/mac/fast/table/table-and-parts-outline-expected.txt (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderTable.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-03-01  Abhishek Arya  <inferno@chromium.org>
+
+        Reviewed by Dave Hyatt.
+
+        Tests that we draw outlines for table and table cells.
+        https://bugs.webkit.org/show_bug.cgi?id=55474
+
+        * fast/table/table-and-parts-outline.html: Added.
+        * platform/mac/fast/table/table-and-parts-outline-expected.checksum: Added.
+        * platform/mac/fast/table/table-and-parts-outline-expected.png: Added.
+        * platform/mac/fast/table/table-and-parts-outline-expected.txt: Added.
+
 2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-03-01  Abhishek Arya  <inferno@chromium.org>
+
+        Reviewed by Dave Hyatt.
+
+        Paint outline for tables.
+        https://bugs.webkit.org/show_bug.cgi?id=55474
+
+        Test: fast/table/table-and-parts-outline.html
+
+        * rendering/RenderTable.cpp:
+        (WebCore::RenderTable::paintObject):
+
 2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebCore/rendering/RenderTable.cpp

@@ -517 +517 @@
         m_currentBorder = 0;
     }
+
+    // Paint outline.
+    if ((paintPhase == PaintPhaseOutline || paintPhase == PaintPhaseSelfOutline) && hasOutline() && style()->visibility() == VISIBLE)
+        paintOutline(paintInfo.context, tx, ty, width(), height());
 }