Changeset 80097 in webkit


Ignore:
Timestamp:
Mar 1, 2011 11:04:18 PM (13 years ago)
Author:
tkent@chromium.org
Message:

2011-03-01 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Assertion fails when a form validation bubble appears
​https://bugs.webkit.org/show_bug.cgi?id=55550

  • fast/forms/interactive-validation-attach-assertion-expected.txt: Added.
  • fast/forms/interactive-validation-attach-assertion.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-01 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Assertion fails when a form validation bubble appears
​https://bugs.webkit.org/show_bug.cgi?id=55550

Test: fast/forms/interactive-validation-attach-assertion.html

  • html/ValidationMessage.cpp: (WebCore::ValidationMessage::buildBubbleTree): Just remove unnecessary attach().

2011-03-01 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Assertion fails when a form validation bubble appears
​https://bugs.webkit.org/show_bug.cgi?id=55550

Test: fast/forms/interactive-validation-attach-assertion.html

  • DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::applyTo): Enable the interactive validation feature by default. This matches to Chromium browser.
Location:
trunk
Files:
2 added
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r80096 r80097  
     12011-03-01  Kent Tamura  <tkent@chromium.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        Assertion fails when a form validation bubble appears
     6        https://bugs.webkit.org/show_bug.cgi?id=55550
     7
     8        * fast/forms/interactive-validation-attach-assertion-expected.txt: Added.
     9        * fast/forms/interactive-validation-attach-assertion.html: Added.
     10        * platform/gtk/Skipped:
     11        * platform/mac/Skipped:
     12        * platform/qt/Skipped:
     13        * platform/win/Skipped:
     14
    1152011-03-01  Kent Tamura  <tkent@chromium.org>
    216

  • trunk/LayoutTests/platform/gtk/Skipped

    r80017 r80097  
    11171117fast/forms/interactive-validation-lost-focusable.html
    11181118fast/forms/interactive-validation-prevented.html
     1119fast/forms/interactive-validation-attach-assertion.html
    11191120
    11201121# Tests that seem to be Mac only, assume that smart drag-and-drop

  • trunk/LayoutTests/platform/mac/Skipped

    r80017 r80097  
    204204fast/forms/interactive-validation-lost-focusable.html
    205205fast/forms/interactive-validation-prevented.html
     206fast/forms/interactive-validation-attach-assertion.html
    206207
    207208# Web Timing is not enabled.

  • trunk/LayoutTests/platform/qt/Skipped

    r80069 r80097  
    29612961fast/forms/interactive-validation-lost-focusable.html
    29622962fast/forms/interactive-validation-prevented.html
     2963fast/forms/interactive-validation-attach-assertion.html
    29632964
    29642965# [Qt] REGRESSION(63862): animations/play-state.html fails intermittently

  • trunk/LayoutTests/platform/win/Skipped

    r80017 r80097  
    10611061fast/forms/interactive-validation-lost-focusable.html
    10621062fast/forms/interactive-validation-prevented.html
     1063fast/forms/interactive-validation-attach-assertion.html
    10631064
    10641065# Web Timing is not enabled.

  • trunk/Source/WebCore/ChangeLog

    r80096 r80097  
     12011-03-01  Kent Tamura  <tkent@chromium.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        Assertion fails when a form validation bubble appears
     6        https://bugs.webkit.org/show_bug.cgi?id=55550
     7
     8        Test: fast/forms/interactive-validation-attach-assertion.html
     9
     10        * html/ValidationMessage.cpp:
     11        (WebCore::ValidationMessage::buildBubbleTree):
     12         Just remove unnecessary attach().
     13
    1142011-03-01  Kent Tamura  <tkent@chromium.org>
    215

  • trunk/Source/WebCore/html/ValidationMessage.cpp

    r76727 r80097  
    122122    if (host->shadowRoot())
    123123        host->shadowRoot()->appendChild(m_bubble.get(), ec);
    124     else {
     124    else
    125125        host->setShadowRoot(m_bubble);
    126         // FIXME: The following attach() should be unnecessary.
    127         m_bubble->attach();
    128     }
    129126
    130127    m_bubble->appendChild(ElementWithPseudoId::create(doc, "-webkit-validation-bubble-top-outer-arrow"), ec);

  • trunk/Tools/ChangeLog

    r80095 r80097  
     12011-03-01  Kent Tamura  <tkent@chromium.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        Assertion fails when a form validation bubble appears
     6        https://bugs.webkit.org/show_bug.cgi?id=55550
     7
     8        Test: fast/forms/interactive-validation-attach-assertion.html
     9
     10        * DumpRenderTree/chromium/WebPreferences.cpp:
     11        (WebPreferences::applyTo): Enable the interactive validation feature by
     12          default. This matches to Chromium browser.
     13
    1142011-03-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
    215

  • trunk/Tools/DumpRenderTree/chromium/WebPreferences.cpp

    r79975 r80097  
    149149    webView->setTabsToLinks(tabsToLinks);
    150150    settings->setCaretBrowsingEnabled(caretBrowsingEnabled);
     151    settings->setAcceleratedCompositingEnabled(acceleratedCompositingEnabled);
     152    settings->setAccelerated2dCanvasEnabled(accelerated2dCanvasEnabled);
    151153
    152154    // Fixed values.
    … …  
    161163    settings->setUsesEncodingDetector(false);
    162164    settings->setImagesEnabled(true);
    163     settings->setAcceleratedCompositingEnabled(acceleratedCompositingEnabled);
    164     settings->setAccelerated2dCanvasEnabled(accelerated2dCanvasEnabled);
     165    settings->setInteractiveFormValidationEnabled(true);
    165166}
    166167
Note: See TracChangeset for help on using the changeset viewer.