Changeset 80152 in webkit

Timestamp:

Mar 2, 2011 11:45:35 AM (13 years ago)

Author:

Adam Roben

Message:

Don't try to capture crash logs on platforms that haven't implemented that feature

Fixes <​http://webkit.org/b/55504> Use of uninitialized value in numeric lt (<) at
Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash

Reviewed by Joseph Pecoraro.

• Scripts/old-run-webkit-tests:

(captureSavedCrashLog): Bail if we don't have a crash log glob.
(findNewestFileMatchingGlob): Fix a buggy test for when no paths match the glob. This isn't
strictly required to fix bug 55504, but seems worthwhile.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/old-run-webkit-tests (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-03-02  Adam Roben  <aroben@apple.com>
+
+        Don't try to capture crash logs on platforms that haven't implemented that feature
+
+        Fixes <http://webkit.org/b/55504> Use of uninitialized value in numeric lt (<) at
+        Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash
+
+        Reviewed by Joseph Pecoraro.
+
+        * Scripts/old-run-webkit-tests:
+        (captureSavedCrashLog): Bail if we don't have a crash log glob.
+        (findNewestFileMatchingGlob): Fix a buggy test for when no paths match the glob. This isn't
+        strictly required to fix bug 55504, but seems worthwhile.
+
 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
 

trunk/Tools/Scripts/old-run-webkit-tests

@@ -1773 +1773 @@
     }
 
+    return unless $glob;
+
     # We assume that the newest crash log in matching the glob is the one that corresponds to the crash that just occurred.
     if (my $newestCrashLog = findNewestFileMatchingGlob($glob)) {
@@ -1789 +1791 @@
 
     my @paths = glob $glob;
-    return unless @paths;
+    return unless scalar(@paths);
 
     my @pathsAndTimes = map { [$_, -M $_] } @paths;