Changeset 80161 in webkit

Timestamp:

Mar 2, 2011 1:33:47 PM (13 years ago)

Author:

Adam Roben

Message:

Look in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer

ReportCrash saves logs to ~/Library/Logs/CrashReporter on Leopard, but to
~/Library/Logs/DiagnosticReports on SnowLeopard. old-run-webkit-tests was only looking in
the former location, but was getting lucky on some SnowLeopard machines because symlinks
were being created there pointing into DiagnosticReports. For machines without these
symlinks, crash logs were not getting captured.

Fixes <​http://webkit.org/b/55607> old-run-webkit-tests doesn't capture crash logs on some
SnowLeopard machines

Reviewed by Eric Seidel.

• Scripts/old-run-webkit-tests:

(captureSavedCrashLog): Look in ~/Library/Logs/DiagnosticReports on SnowLeopard and newer.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/old-run-webkit-tests (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-03-02  Adam Roben  <aroben@apple.com>
+
+        Look in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer
+
+        ReportCrash saves logs to ~/Library/Logs/CrashReporter on Leopard, but to
+        ~/Library/Logs/DiagnosticReports on SnowLeopard. old-run-webkit-tests was only looking in
+        the former location, but was getting lucky on some SnowLeopard machines because symlinks
+        were being created there pointing into DiagnosticReports. For machines without these
+        symlinks, crash logs were not getting captured.
+
+        Fixes <http://webkit.org/b/55607> old-run-webkit-tests doesn't capture crash logs on some
+        SnowLeopard machines
+
+        Reviewed by Eric Seidel.
+
+        * Scripts/old-run-webkit-tests:
+        (captureSavedCrashLog): Look in ~/Library/Logs/DiagnosticReports on SnowLeopard and newer.
+
 2011-03-02  Adam Roben  <aroben@apple.com>
 

trunk/Tools/Scripts/old-run-webkit-tests

@@ -1761 +1761 @@
         $glob = File::Spec->catfile($testResultsDirectory, $windowsCrashLogFilePrefix . "*.txt");
     } elsif (isAppleMacWebKit()) {
-        $glob = File::Spec->catfile("~", "Library", "Logs", "CrashReporter", ($webProcessCrashed ? "WebProcess" : $dumpToolName) . "_*.crash");
+        my $crashLogDirectoryName;
+        if (isTiger() || isLeopard()) {
+            $crashLogDirectoryName = "CrashReporter";
+        } else {
+            $crashLogDirectoryName = "DiagnosticReports";
+        }
+
+        $glob = File::Spec->catfile("~", "Library", "Logs", $crashLogDirectoryName, ($webProcessCrashed ? "WebProcess" : $dumpToolName) . "_*.crash");
 
         # Even though the dump tool has exited, CrashReporter might still be running. We need to