Changeset 80221 in webkit


Ignore:
Timestamp:
Mar 3, 2011 2:44:39 AM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-03-03 Benjamin Poulain <ikipou@gmail.com>

Reviewed by Adam Roben.

REGRESSION (r79817): Lots of leaks of FloatingObjects seen on SnowLeopard Intel Leaks bot
https://bugs.webkit.org/show_bug.cgi?id=55602

Delete the FloatingObject referenced by m_floatingObjects when clearing the floats.

The DeprecatedPtrList was deleting the objects automatically due to its autoDelete behavior. The
objects need to be deleted manually with ListHashSet.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::clearFloats):
Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r80220 r80221  
     12011-03-03  Benjamin Poulain  <ikipou@gmail.com>
     2
     3        Reviewed by Adam Roben.
     4
     5        REGRESSION (r79817): Lots of leaks of FloatingObjects seen on SnowLeopard Intel Leaks bot
     6        https://bugs.webkit.org/show_bug.cgi?id=55602
     7
     8        Delete the FloatingObject referenced by m_floatingObjects when clearing the floats.
     9
     10        The DeprecatedPtrList was deleting the objects automatically due to its autoDelete behavior. The
     11        objects need to be deleted manually with ListHashSet.
     12
     13        * rendering/RenderBlock.cpp:
     14        (WebCore::RenderBlock::clearFloats):
     15
    1162011-03-03  Hans Wennborg  <hans@chromium.org>
    217
  • trunk/Source/WebCore/rendering/RenderBlock.cpp

    r79930 r80221  
    35093509    // Inline blocks are covered by the isReplaced() check in the avoidFloats method.
    35103510    if (avoidsFloats() || isRoot() || isRenderView() || isFloatingOrPositioned() || isTableCell()) {
    3511         if (m_floatingObjects)
     3511        if (m_floatingObjects) {
     3512            deleteAllValues(*m_floatingObjects);
    35123513            m_floatingObjects->clear();
     3514        }
    35133515        return;
    35143516    }
Note: See TracChangeset for help on using the changeset viewer.