Changeset 80250 in webkit

Timestamp:

Mar 3, 2011 9:43:37 AM (13 years ago)

Author:

helder@sencha.com

Message:

[Qt] fast/canvas/canvas-strokePath-gradient-shadow.html fails
​https://bugs.webkit.org/show_bug.cgi?id=55651

Reviewed by Andreas Kling.

When relying on ContextShadow and using a gradient stroke for a path,
the alpha of the shadow is incorrect.

Source/WebCore:

• platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::strokePath):

LayoutTests:

• platform/qt/Skipped: Remove test from skipped list.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/qt/Skipped (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/qt/GraphicsContextQt.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-03-03  Helder Correia  <helder@sencha.com>
+
+        Reviewed by Andreas Kling.
+
+        [Qt] fast/canvas/canvas-strokePath-gradient-shadow.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=55651
+
+        When relying on ContextShadow and using a gradient stroke for a path,
+        the alpha of the shadow is incorrect.
+
+        * platform/qt/Skipped: Remove test from skipped list.
+
 2011-03-03  Philippe Normand  <pnormand@igalia.com>
 

trunk/LayoutTests/platform/qt/Skipped

@@ -1585 +1585 @@
 fast/text/word-break-run-rounding.html
 fast/transforms/transform-positioned-ancestor.html
-fast/canvas/canvas-strokePath-gradient-shadow.html
 
 # -- timedout with --platform mac --ignore-metrics

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-03-03  Helder Correia  <helder@sencha.com>
+
+        Reviewed by Andreas Kling.
+
+        [Qt] fast/canvas/canvas-strokePath-gradient-shadow.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=55651
+
+        When relying on ContextShadow and using a gradient stroke for a path,
+        the alpha of the shadow is incorrect.
+
+        * platform/graphics/qt/GraphicsContextQt.cpp:
+        (WebCore::GraphicsContext::strokePath):
+
 2011-03-03  Martin Robinson  <mrobinson@igalia.com>
 

trunk/Source/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

@@ -556 +556 @@
             QPainter* shadowPainter = shadow->beginShadowLayer(this, boundingRect);
             if (shadowPainter) {
-                shadowPainter->setOpacity(static_cast<qreal>(m_data->shadow.m_color.alpha()) / 255);
-                shadowPainter->strokePath(platformPath, pen);
+                if (m_state.strokeGradient) {
+                    QBrush brush(*m_state.strokeGradient->platformGradient());
+                    brush.setTransform(m_state.strokeGradient->gradientSpaceTransform());
+                    QPen shadowPen(pen);
+                    shadowPen.setBrush(brush);
+                    shadowPainter->setOpacity(static_cast<qreal>(shadow->m_color.alpha()) / 255);
+                    shadowPainter->strokePath(platformPath, shadowPen);
+                } else {
+                    shadowPainter->setOpacity(static_cast<qreal>(m_data->shadow.m_color.alpha()) / 255);
+                    shadowPainter->strokePath(platformPath, pen);
+                }
                 shadow->endShadowLayer(this);
             }