Changeset 80262 in webkit

Timestamp:

Mar 3, 2011 11:15:58 AM (13 years ago)

Author:

tonyg@chromium.org

Message:

2011-03-03 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Mihai Parparita.

Teach sheriffbot to answer whois commands
​https://bugs.webkit.org/show_bug.cgi?id=55687

• Scripts/webkitpy/tool/bot/irc_command.py:
• Scripts/webkitpy/tool/bot/irc_command_unittest.py:
• Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/bot/irc_command.py (modified) (3 diffs)
• Scripts/webkitpy/tool/bot/irc_command_unittest.py (modified) (1 diff)
• Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-03-03  Tony Gentilcore  <tonyg@chromium.org>
+
+        Reviewed by Mihai Parparita.
+
+        Teach sheriffbot to answer whois commands
+        https://bugs.webkit.org/show_bug.cgi?id=55687
+
+        * Scripts/webkitpy/tool/bot/irc_command.py:
+        * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
+        * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
+
 2011-03-03  Victoria Kirst  <vrk@google.com>
 

trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py

@@ -31 +31 @@
 
 from webkitpy.common.config import urls
+from webkitpy.common.config.committers import CommitterList
 from webkitpy.common.net.bugzilla import parse_bug_id
 from webkitpy.common.system.executive import ScriptError
@@ -110 +111 @@
 
 
+class Whois(IRCCommand):
+    def execute(self, nick, args, tool, sheriff):
+        if len(args) != 1:
+            return "%s: Usage: BUGZILLA_EMAIL" % nick
+        email = args[0]
+        committer = CommitterList().committer_by_email(email)
+        if not committer:
+            return "%s: Sorry, I don't know %s. Maybe you could introduce me?" % (nick, email)
+        if not committer.irc_nickname:
+            return "%s: %s hasn't told me their nick. Boo hoo :-(" % (nick, email)
+        return "%s: %s is %s. Why do you ask?" % (nick, email, committer.irc_nickname)
+
+
 class Eliza(IRCCommand):
     therapist = None
@@ -124 +138 @@
 # FIXME: Lame.  We should have an auto-registering CommandCenter.
 commands = {
+    "help": Help,
+    "hi": Hi,
     "last-green-revision": LastGreenRevision,
     "restart": Restart,
     "rollout": Rollout,
-    "help": Help,
-    "hi": Hi,
+    "whois": Whois,
 }

trunk/Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py

@@ -37 +37 @@
         eliza.execute("tom", "hi", None, None)
         eliza.execute("tom", "bye", None, None)
+
+    def test_whois(self):
+        whois = Whois()
+        self.assertEquals("tom: Usage: BUGZILLA_EMAIL",
+                          whois.execute("tom", [], None, None))
+        self.assertEquals("tom: Usage: BUGZILLA_EMAIL",
+                          whois.execute("tom", ["Adam", "Barth"], None, None))
+        self.assertEquals("tom: Sorry, I don't know unknown@example.com. Maybe you could introduce me?",
+                          whois.execute("tom", ["unknown@example.com"], None, None))
+        self.assertEquals("tom: tonyg@chromium.org is tonyg-cr. Why do you ask?",
+                          whois.execute("tom", ["tonyg@chromium.org"], None, None))
+        self.assertEquals("tom: vicki@apple.com hasn't told me their nick. Boo hoo :-(",
+                          whois.execute("tom", ["vicki@apple.com"], None, None))

trunk/Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py

@@ -52 +52 @@
 
     def test_help(self):
-        expected_stderr = "MOCK: irc.post: mock_nick: Available commands: rollout, hi, help, restart, last-green-revision\n"
+        expected_stderr = "MOCK: irc.post: mock_nick: Available commands: whois, hi, last-green-revision, rollout, restart, help\n"
         OutputCapture().assert_outputs(self, run, args=["help"], expected_stderr=expected_stderr)