Changeset 80345 in webkit


Ignore:
Timestamp:
Mar 4, 2011 5:26:23 AM (13 years ago)
Author:
loislo@chromium.org
Message:

2011-03-04 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Remove unnecessary domain and success flags from the response messages.
​https://bugs.webkit.org/show_bug.cgi?id=55768

We have domain property in the response messages but it is not used because we dispatch
the responses on the callback associated with seq.

If we have property 'errors' in the response then success eq false and true in the other case.

  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/report-protocol-errors-expected.txt:

2011-03-04 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Remove unnecessary domain and success flags from the response messages.
​https://bugs.webkit.org/show_bug.cgi?id=55768

We have domain property in the response messages but it is not used because we dispatch
the responses on the callback associated with seq.

If we have property 'errors' in the response then success eq false and true in the other case.

  • inspector/CodeGeneratorInspector.pm:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r80343 r80345  
     12011-03-04  Ilya Tikhonovsky  <loislo@chromium.org>
     2
     3        Reviewed by Yury Semikhatsky.
     4
     5        Web Inspector: Remove unnecessary domain and success flags from the response messages.
     6        https://bugs.webkit.org/show_bug.cgi?id=55768
     7
     8        We have domain property in the response messages but it is not used because we dispatch
     9        the responses on the callback associated with seq.
     10
     11        If we have property 'errors' in the response then success eq false and true in the other case.
     12
     13        * inspector/protocol/runtime-agent-expected.txt:
     14        * inspector/report-protocol-errors-expected.txt:
     15
    1162011-03-04  Csaba Osztrogonác  <ossy@webkit.org>
    217

  • trunk/LayoutTests/inspector/protocol/runtime-agent-expected.txt

    r80342 r80345  
    1919{
    2020    seq : <number>
    21     domain : "Runtime"
    22     success : true
    2321    body : {
    2422        result : {
    … …  
    5654{
    5755    seq : <number>
    58     domain : "Runtime"
    59     success : true
    6056    body : {
    6157        result : {
    … …  
    9086{
    9187    seq : <number>
    92     domain : "Runtime"
    93     success : true
    9488    body : {
    9589        result : true
    … …  
    119113{
    120114    seq : <number>
    121     domain : "Runtime"
    122     success : true
    123115    body : {
    124116        result : true
    … …  
    148140{
    149141    seq : <number>
    150     domain : "Runtime"
    151     success : true
    152142    body : {
    153143        result : {
    … …  
    207197{
    208198    seq : <number>
    209     domain : "Runtime"
    210     success : true
    211199}
    212200
    … …  
    228216{
    229217    seq : <number>
    230     domain : "Runtime"
    231     success : true
    232218}
    233219

  • trunk/LayoutTests/inspector/report-protocol-errors-expected.txt

    r80230 r80345  
    33{
    44    seq : 0
    5     success : false
    65    errors : {
    76        0 : "Protocol Error: Invalid message format. Message should be in JSON format."
    … …  
    109{
    1110    seq : 0
    12     success : false
    1311    errors : {
    1412        0 : "Protocol Error: Invalid message format. 'command' property wasn't found."
    … …  
    1715{
    1816    seq : 0
    19     success : false
    2017    errors : {
    2118        0 : "Protocol Error: Invalid message format. The type of 'command' property should be string."
    … …  
    2421{
    2522    seq : 0
    26     success : false
    2723    errors : {
    2824        0 : "Protocol Error: Invalid message format. 'seq' property was not found in the request."
    … …  
    3127{
    3228    seq : 0
    33     success : false
    3429    errors : {
    3530        0 : "Protocol Error: Invalid message format. The type of 'seq' property should be number."
    … …  
    3833{
    3934    seq : 1
    40     success : false
    4135    errors : {
    4236        0 : "Protocol Error: Invalid command was received. 'test' wasn't found in domain DOM."
    … …  
    4539{
    4640    seq : 2
    47     domain : "Network"
    48     success : false
    4941    errors : {
    5042        0 : "Protocol Error: 'arguments' property with type 'object' was not found."
    … …  
    5345{
    5446    seq : 3
    55     domain : "Network"
    56     success : false
    5747    errors : {
    5848        0 : "Protocol Error: 'arguments' property with type 'object' was not found."
    … …  
    6151{
    6252    seq : 4
    63     domain : "Network"
    64     success : false
    6553    errors : {
    6654        0 : "Protocol Error: Argument 'frameId' with type 'Number' was not found."
    … …  
    7159{
    7260    seq : 5
    73     domain : "Network"
    74     success : false
    7561    errors : {
    7662        0 : "Protocol Error: Argument 'frameId' with type 'Number' was not found."

  • trunk/Source/WebCore/ChangeLog

    r80344 r80345  
     12011-03-04  Ilya Tikhonovsky  <loislo@chromium.org>
     2
     3        Reviewed by Yury Semikhatsky.
     4
     5        Web Inspector: Remove unnecessary domain and success flags from the response messages.
     6        https://bugs.webkit.org/show_bug.cgi?id=55768
     7
     8        We have domain property in the response messages but it is not used because we dispatch
     9        the responses on the callback associated with seq.
     10
     11        If we have property 'errors' in the response then success eq false and true in the other case.
     12
     13        * inspector/CodeGeneratorInspector.pm:
     14
    1152011-03-04  Christian Dywan  <christian@lanedo.com>
    216

  • trunk/Source/WebCore/inspector/CodeGeneratorInspector.pm

    r80230 r80345  
    514514    push(@function, "        RefPtr<InspectorObject> responseMessage = InspectorObject::create();");
    515515    push(@function, "        responseMessage->setNumber(\"seq\", callId);");
    516     push(@function, "        responseMessage->setString(\"domain\", \"$domain\");");
    517     push(@function, "        responseMessage->setBoolean(\"success\", !protocolErrors->length());");
    518516    push(@function, "");
    519517    push(@function, "        if (protocolErrors->length())");
    … …  
    601599    RefPtr<InspectorObject> message = InspectorObject::create();
    602600    message->setNumber("seq", callId);
    603     message->setBoolean("success", false);
    604601    RefPtr<InspectorArray> errors = InspectorArray::create();
    605602    errors->pushString(errorText);
    … …  
    849846
    850847        if ("seq" in messageObject) { // just a response for some request
    851             if (messageObject.success)
     848            if (!messageObject.errors)
    852849                this._callbacks[messageObject.seq].apply(null, arguments);
    853850            else
Note: See TracChangeset for help on using the changeset viewer.