Changeset 80365 in webkit


Ignore:
Timestamp:
Mar 4, 2011 10:08:52 AM (13 years ago)
Author:
jeffm@apple.com
Message:

2011-03-04 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Move WKViewExecuteCommand() to WKPageExecuteCommand()
https://bugs.webkit.org/show_bug.cgi?id=55744


Executing a command operates on a page, so it makes more sense for it to be in WKPage.
This also makes it available on all platforms, not just Windows.

  • UIProcess/API/C/WKPage.cpp: (WKPageExecuteCommand): Added.
  • UIProcess/API/C/WKPage.h: Add WKPageExecuteCommand().
  • UIProcess/API/C/win/WKView.cpp: Remove WKViewExecuteCommand().
  • UIProcess/API/C/win/WKView.h: Remove WKViewExecuteCommand().
Location:
trunk/Source/WebKit2
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r80359 r80365  
     12011-03-04  Jeff Miller  <jeffm@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        Move WKViewExecuteCommand() to WKPageExecuteCommand()
     6        https://bugs.webkit.org/show_bug.cgi?id=55744
     7       
     8        Executing a command operates on a page, so it makes more sense for it to be in WKPage.
     9        This also makes it available on all platforms, not just Windows.
     10
     11        * UIProcess/API/C/WKPage.cpp:
     12        (WKPageExecuteCommand): Added.
     13        * UIProcess/API/C/WKPage.h: Add WKPageExecuteCommand().
     14        * UIProcess/API/C/win/WKView.cpp: Remove WKViewExecuteCommand().
     15        * UIProcess/API/C/win/WKView.h: Remove WKViewExecuteCommand().
     16
    1172011-03-04  Dan Bernstein  <mitz@apple.com>
    218
  • trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp

    r80358 r80365  
    493493    return WebPageProxy::debugPaintFlags();
    494494}
     495
     496void WKPageExecuteCommand(WKPageRef pageRef, WKStringRef command)
     497{
     498    toImpl(pageRef)->executeEditCommand(toImpl(command)->string());
     499}
  • trunk/Source/WebKit2/UIProcess/API/C/WKPage.h

    r80358 r80365  
    364364WK_EXPORT void WKPageForceRepaint(WKPageRef page, void* context, WKPageForceRepaintFunction function);
    365365
     366/*
     367    Some of the more common command name strings include the following, although any WebCore EditorCommand string is supported:
     368   
     369    "Cut"
     370    "Copy"
     371    "Paste"
     372    "SelectAll"
     373    "Undo"
     374    "Redo"
     375*/
     376
     377WK_EXPORT void WKPageExecuteCommand(WKPageRef page, WKStringRef command);
     378
    366379#ifdef __cplusplus
    367380}
  • trunk/Source/WebKit2/UIProcess/API/C/win/WKView.cpp

    r80295 r80365  
    8282    return toImpl(viewRef)->getFindIndicatorCallback(context);
    8383}
    84 
    85 void WKViewExecuteCommand(WKViewRef viewRef, WKStringRef command)
    86 {
    87     toImpl(viewRef)->page()->executeEditCommand(toImpl(command)->string());
    88 }
  • trunk/Source/WebKit2/UIProcess/API/C/win/WKView.h

    r80295 r80365  
    5151WK_EXPORT WKViewFindIndicatorCallback WKViewGetFindIndicatorCallback(WKViewRef view, void** context);
    5252
    53 /*
    54     Valid command name strings include:
    55    
    56     "Cut"
    57     "Copy"
    58     "Paste"
    59     "SelectAll"
    60     "Undo"
    61     "Redo"
    62 */
    63 
    64 WK_EXPORT void WKViewExecuteCommand(WKViewRef view, WKStringRef command);
    65 
    6653#ifdef __cplusplus
    6754}
Note: See TracChangeset for help on using the changeset viewer.