Changeset 80371 in webkit

Timestamp:

Mar 4, 2011 1:28:09 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-03-04 Cosmin Truta <​ctruta@chromium.org>

Reviewed by Adam Barth.

Clarify comment about potential memory leak in SVGImage
​https://bugs.webkit.org/show_bug.cgi?id=55362

No functionality change. No new tests.

• svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• svg/graphics/SVGImage.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-03-04  Cosmin Truta  <ctruta@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        Clarify comment about potential memory leak in SVGImage
+        https://bugs.webkit.org/show_bug.cgi?id=55362
+
+        No functionality change. No new tests.
+
+        * svg/graphics/SVGImage.cpp:
+        (WebCore::SVGImage::dataChanged):
+
 2011-03-04  Jessie Berlin  <jberlin@apple.com>
 

trunk/Source/WebCore/svg/graphics/SVGImage.cpp

@@ -264 +264 @@
 
         // FIXME: If this SVG ends up loading itself, we might leak the world.
-        // The comment said that the Cache code does not know about CachedImages
-        // holding Frames and won't know to break the cycle. But 
+        // The Cache code does not know about CachedImages holding Frames and
+        // won't know to break the cycle.
+        // This will become an issue when SVGImage will be able to load other
+        // SVGImage objects, but we're safe now, because SVGImage can only be
+        // loaded by a top-level document.
         m_page.set(new Page(pageClients));
         m_page->settings()->setMediaEnabled(false);