Changeset 80451 in webkit
- Timestamp:
- Mar 6, 2011 9:41:20 PM (13 years ago)
- Location:
- trunk/Source/WebKit/chromium
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/chromium/ChangeLog
r80437 r80451 1 2011-03-06 Sreeram Ramachandran <sreeram@google.com> 2 3 Reviewed by Dimitri Glazkov. 4 5 Expose page dismissal event status through the WebKit API for chromium. 6 https://bugs.webkit.org/show_bug.cgi?id=55844 7 8 Chromium will find it useful to know the page dismissal status (i.e., 9 whether a frame is in the midst of executing a beforeunload or unload 10 handler), so expose that information through the chromium port in the 11 WebKit API. 12 13 This is my second attempt at this patch. The previous one broke 14 downstream Chromium builds of some unit tests which had classes derived 15 from WebFrame (and thus became uninstantiable because of this new pure 16 virtual method). Those have now been fixed (http://crrev.com/77101). 17 18 * public/WebFrame.h: 19 * src/WebFrameImpl.cpp: 20 (WebKit::WebFrameImpl::pageDismissalEventBeingDispatched): 21 * src/WebFrameImpl.h: 22 1 23 2011-03-06 Sheriff Bot <webkit.review.bot@gmail.com> 2 24 -
trunk/Source/WebKit/chromium/public/WebFrame.h
r80437 r80451 366 366 virtual bool willSuppressOpenerInNewFrame() const = 0; 367 367 368 // Returns true if this frame is in the midst of executing a beforeunload 369 // or unload event handler. 370 virtual bool pageDismissalEventBeingDispatched() const = 0; 371 368 372 369 373 // Editing ------------------------------------------------------------- -
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
r80437 r80451 1078 1078 } 1079 1079 1080 bool WebFrameImpl::pageDismissalEventBeingDispatched() const 1081 { 1082 return frame()->loader()->pageDismissalEventBeingDispatched(); 1083 } 1084 1080 1085 void WebFrameImpl::replaceSelection(const WebString& text) 1081 1086 { -
trunk/Source/WebKit/chromium/src/WebFrameImpl.h
r80437 r80451 139 139 virtual bool isProcessingUserGesture() const; 140 140 virtual bool willSuppressOpenerInNewFrame() const; 141 virtual bool pageDismissalEventBeingDispatched() const; 141 142 virtual void replaceSelection(const WebString&); 142 143 virtual void insertText(const WebString&);
Note: See TracChangeset
for help on using the changeset viewer.