Changeset 80451 in webkit


Ignore:
Timestamp:
Mar 6, 2011 9:41:20 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-03-06 Sreeram Ramachandran <sreeram@google.com>

Reviewed by Dimitri Glazkov.

Expose page dismissal event status through the WebKit API for chromium.
https://bugs.webkit.org/show_bug.cgi?id=55844

Chromium will find it useful to know the page dismissal status (i.e.,
whether a frame is in the midst of executing a beforeunload or unload
handler), so expose that information through the chromium port in the
WebKit API.

This is my second attempt at this patch. The previous one broke
downstream Chromium builds of some unit tests which had classes derived
from WebFrame (and thus became uninstantiable because of this new pure
virtual method). Those have now been fixed (http://crrev.com/77101).

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::pageDismissalEventBeingDispatched):
  • src/WebFrameImpl.h:
Location:
trunk/Source/WebKit/chromium
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/chromium/ChangeLog

    r80437 r80451  
     12011-03-06  Sreeram Ramachandran  <sreeram@google.com>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        Expose page dismissal event status through the WebKit API for chromium.
     6        https://bugs.webkit.org/show_bug.cgi?id=55844
     7
     8        Chromium will find it useful to know the page dismissal status (i.e.,
     9        whether a frame is in the midst of executing a beforeunload or unload
     10        handler), so expose that information through the chromium port in the
     11        WebKit API.
     12     
     13        This is my second attempt at this patch. The previous one broke
     14        downstream Chromium builds of some unit tests which had classes derived
     15        from WebFrame (and thus became uninstantiable because of this new pure
     16        virtual method). Those have now been fixed (http://crrev.com/77101).
     17
     18        * public/WebFrame.h:
     19        * src/WebFrameImpl.cpp:
     20        (WebKit::WebFrameImpl::pageDismissalEventBeingDispatched):
     21        * src/WebFrameImpl.h:
     22
    1232011-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
    224
  • trunk/Source/WebKit/chromium/public/WebFrame.h

    r80437 r80451  
    366366    virtual bool willSuppressOpenerInNewFrame() const = 0;
    367367
     368    // Returns true if this frame is in the midst of executing a beforeunload
     369    // or unload event handler.
     370    virtual bool pageDismissalEventBeingDispatched() const = 0;
     371
    368372
    369373    // Editing -------------------------------------------------------------
  • trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp

    r80437 r80451  
    10781078}
    10791079
     1080bool WebFrameImpl::pageDismissalEventBeingDispatched() const
     1081{
     1082    return frame()->loader()->pageDismissalEventBeingDispatched();
     1083}
     1084
    10801085void WebFrameImpl::replaceSelection(const WebString& text)
    10811086{
  • trunk/Source/WebKit/chromium/src/WebFrameImpl.h

    r80437 r80451  
    139139    virtual bool isProcessingUserGesture() const;
    140140    virtual bool willSuppressOpenerInNewFrame() const;
     141    virtual bool pageDismissalEventBeingDispatched() const;
    141142    virtual void replaceSelection(const WebString&);
    142143    virtual void insertText(const WebString&);
Note: See TracChangeset for help on using the changeset viewer.