Changeset 80514 in webkit

Timestamp:

Mar 7, 2011 5:37:00 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-03-07 Justin Novosad <​junov@chromium.org>

Reviewed by Kenneth Russell.

Fix for blurs behind bitmap images in Chromium, and boosting
shadow blur quality
Bug URLs:

​https://bugs.webkit.org/show_bug.cgi?id=55410
​https://bugs.webkit.org/show_bug.cgi?id=55506

No new tests. Covered by existing layout tests.

• platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow): Turn on high quality shadows and fix shadow color
• platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap): Propagate the draw looper from context to painter

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/skia/GraphicsContextSkia.cpp (modified) (2 diffs)
• platform/graphics/skia/ImageSkia.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-03-07  Justin Novosad  <junov@chromium.org>
+
+        Reviewed by Kenneth Russell.
+
+        Fix for blurs behind bitmap images in Chromium, and boosting
+        shadow blur quality 
+        Bug URLs:
+                https://bugs.webkit.org/show_bug.cgi?id=55410
+                https://bugs.webkit.org/show_bug.cgi?id=55506
+
+        No new tests. Covered by existing layout tests. 
+
+        * platform/graphics/skia/GraphicsContextSkia.cpp:
+        (WebCore::GraphicsContext::setPlatformShadow): Turn on high quality shadows and fix shadow color
+        * platform/graphics/skia/ImageSkia.cpp:
+        (WebCore::paintSkBitmap): Propagate the draw looper from context to painter
+
 2011-03-07  Andreas Kling  <kling@webkit.org>
 

trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp

@@ -1036 +1036 @@
     double blur = blurFloat;
 
-    SkBlurDrawLooper::BlurFlags blurFlags = SkBlurDrawLooper::kNone_BlurFlag;
+    uint32_t blurFlags = SkBlurDrawLooper::kHighQuality_BlurFlag | 
+        SkBlurDrawLooper::kOverrideColor_BlurFlag;
 
     if (m_state.shadowsIgnoreTransforms)  {
@@ -1043 +1044 @@
         // Transforms. So with this flag set, we know this state is associated
         // with a CanvasRenderingContext.
-        blurFlags = SkBlurDrawLooper::kIgnoreTransform_BlurFlag;
+        blurFlags |= SkBlurDrawLooper::kIgnoreTransform_BlurFlag;
         
         // CG uses natural orientation for Y axis, but the HTML5 canvas spec

trunk/Source/WebCore/platform/graphics/skia/ImageSkia.cpp

@@ -261 +261 @@
     paint.setFilterBitmap(true);
     paint.setAlpha(platformContext->getNormalizedAlpha());
+    paint.setLooper(platformContext->getDrawLooper());
 
     skia::PlatformCanvas* canvas = platformContext->canvas();