Changeset 80521 in webkit

Timestamp:

Mar 7, 2011 6:19:16 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-03-07 Alice Boxhall <​aboxhall@chromium.org>

Reviewed by Adam Barth.

Fix platform/image-encoders/JPEGImageEncoder.cpp empty_output_buffer() behaviour
​https://bugs.webkit.org/show_bug.cgi?id=54522

Fix jpegEmptyOutputBuffer() by ignoring free_in_buffer value as required.

No new tests, as this code is not yet used in WebKit. Once this code is used to implement canvas.toDataUrl(), the canvas tests will exercise it.

• platform/image-encoders/JPEGImageEncoder.cpp: (WebCore::jpegEmptyOutputBuffer):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/image-encoders/JPEGImageEncoder.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-03-07  Alice Boxhall  <aboxhall@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        Fix platform/image-encoders/JPEGImageEncoder.cpp empty_output_buffer() behaviour
+        https://bugs.webkit.org/show_bug.cgi?id=54522
+
+        Fix jpegEmptyOutputBuffer() by ignoring free_in_buffer value as required.
+
+        No new tests, as this code is not yet used in WebKit. Once this code is used to implement canvas.toDataUrl(), the canvas tests will exercise it.
+
+        * platform/image-encoders/JPEGImageEncoder.cpp:
+        (WebCore::jpegEmptyOutputBuffer):
+
 2011-03-07  Sergey Glazunov  <serg.glazunov@gmail.com>
 

trunk/Source/WebCore/platform/image-encoders/JPEGImageEncoder.cpp

@@ -66 +66 @@
 {
     JPEGDestinationManager* dest = static_cast<JPEGDestinationManager*>(compressData->dest);
-    dest->m_dump.append(dest->m_buffer.data(), dest->m_buffer.size() - dest->free_in_buffer);
+    dest->m_dump.append(dest->m_buffer.data(), dest->m_buffer.size());
     dest->next_output_byte  = reinterpret_cast<JOCTET*>(dest->m_buffer.data());
     dest->free_in_buffer    = dest->m_buffer.size();