Changeset 80523 in webkit

Timestamp:

Mar 7, 2011 6:32:53 PM (13 years ago)

Author:

andersca@apple.com

Message:

2011-03-07 Damian Kaleta <​dkaleta@apple.com>

Reviewed by Anders Carlsson.

QuickTime plugin should opt in to a 32-bit non-executable heap
​https://bugs.webkit.org/show_bug.cgi?id=55704
<rdar://problem/8105706>

• UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::pluginNeedsExecutableHeap): Decides per plugin if it should opt-in to a 32-bit non-executable heap. By default it should opt-out. (WebKit::PluginProcessProxy::PluginProcessProxy):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Plugins/PluginProcessProxy.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-03-07  Damian Kaleta  <dkaleta@apple.com>
+
+        Reviewed by Anders Carlsson.
+
+        QuickTime plugin should opt in to a 32-bit non-executable heap
+        https://bugs.webkit.org/show_bug.cgi?id=55704
+        <rdar://problem/8105706>
+
+        * UIProcess/Plugins/PluginProcessProxy.cpp:
+        (WebKit::pluginNeedsExecutableHeap): Decides per plugin if it should opt-in to a 32-bit non-executable heap.
+        By default it should opt-out.
+        (WebKit::PluginProcessProxy::PluginProcessProxy):
+
 2011-03-07  Sam Weinig  <sam@webkit.org>
 

trunk/Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp

@@ -39 +39 @@
 
 namespace WebKit {
+    
+#if PLATFORM(MAC)
+static bool pluginNeedsExecutableHeap(const PluginInfoStore::Plugin& pluginInfo)
+{
+    if (pluginInfo.bundleIdentifier == "com.apple.QuickTime Plugin.plugin")
+        return false;
+    
+    return true;
+}
+#endif
 
 PassOwnPtr<PluginProcessProxy> PluginProcessProxy::create(PluginProcessManager* PluginProcessManager, const PluginInfoStore::Plugin& pluginInfo)
@@ -54 +64 @@
 #if PLATFORM(MAC)
     launchOptions.architecture = pluginInfo.pluginArchitecture;
-
-    // FIXME: This shouldn't be true for all plug-ins.
-    launchOptions.executableHeap = true;
+    launchOptions.executableHeap = pluginNeedsExecutableHeap(pluginInfo);
 #endif