Changeset 80554 in webkit

Timestamp:

Mar 8, 2011 2:00:38 AM (13 years ago)

Author:

Carlos Garcia Campos

Message:

2011-03-08 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Use doubles instead of integers for coordinates when rendering arrows
​https://bugs.webkit.org/show_bug.cgi?id=55866

To prevent off-by-one rounding errors.

• platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::paintMenuList):
• platform/gtk/ScrollbarThemeGtk3.cpp: (WebCore::ScrollbarThemeGtk::paintButton):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/gtk/RenderThemeGtk3.cpp (modified) (2 diffs)
• platform/gtk/ScrollbarThemeGtk3.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Reviewed by Martin Robinson.
+
+        [GTK] Use doubles instead of integers for coordinates when rendering arrows
+        https://bugs.webkit.org/show_bug.cgi?id=55866
+
+        To prevent off-by-one rounding errors.
+
+        * platform/gtk/RenderThemeGtk3.cpp:
+        (WebCore::RenderThemeGtk::paintMenuList):
+        * platform/gtk/ScrollbarThemeGtk3.cpp:
+        (WebCore::ScrollbarThemeGtk::paintButton):
+
 2011-03-08  Markus Goetz  <guruz@guruz.de>
 

trunk/Source/WebCore/platform/gtk/RenderThemeGtk3.cpp

@@ -484 +484 @@
 
     IntSize arrowSize(minArrowSize, innerRect.height());
-    IntPoint arrowPosition = innerRect.location();
+    FloatPoint arrowPosition(innerRect.location());
     if (direction == GTK_TEXT_DIR_LTR)
         arrowPosition.move(innerRect.width() - arrowSize.width(), 0);
@@ -491 +491 @@
     // don't have a widget here, we are just using the default xalign and valign values of 0.5.
     gint extent = std::min(arrowSize.width(), arrowSize.height()) * arrowScaling;
-    arrowPosition.move(std::floor((arrowSize.width() - extent) / 2), std::floor((arrowSize.height() - extent) / 2));
+    arrowPosition.move((arrowSize.width() - extent) / 2, (arrowSize.height() - extent) / 2);
 
     gtk_style_context_set_state(arrowStyleContext, state);

trunk/Source/WebCore/platform/gtk/ScrollbarThemeGtk3.cpp

@@ -168 +168 @@
     IntSize arrowSize = rect.size();
     arrowSize.scale(arrowScaling);
-    IntPoint arrowPoint(rect.x() + (rect.width() - arrowSize.width()) / 2,
-                        rect.y() + (rect.height() - arrowSize.height()) / 2);
+    FloatPoint arrowPoint(rect.x() + (rect.width() - arrowSize.width()) / 2,
+                          rect.y() + (rect.height() - arrowSize.height()) / 2);
 
     if (flags & GTK_STATE_FLAG_ACTIVE) {