Changeset 80587 in webkit


Ignore:
Timestamp:
Mar 8, 2011 1:49:04 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-03-08 Joe Wild <​joseph.wild@nokia.com>

Reviewed by Csaba Osztrogonác.

[Qt] Missing SVG variables
​https://bugs.webkit.org/show_bug.cgi?id=32941

Basically, this patch just modifies features.pri to the Qt build to
pass on the ENABLE_SVG_* flags to the IDL binding generator.

Also I had remove global-construtors.html from the skip list and
updated the associated expected results files.

  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:

2011-03-08 Joe Wild <​joseph.wild@nokia.com>

Reviewed by Csaba Osztrogonác.

[Qt] Missing SVG variables
​https://bugs.webkit.org/show_bug.cgi?id=32941

Basically, this patch just modifies features.pri to the Qt build to
pass on the ENABLE_SVG_* flags to the IDL binding generator.

Also I had remove global-construtors.html from the skip list and
updated the associated expected results files.

  • features.pri:
  • page/DOMWindow.idl:
Location:
trunk
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r80582 r80587  
     12011-03-08  Joe Wild  <joseph.wild@nokia.com>
     2
     3        Reviewed by Csaba Osztrogonác.
     4
     5        [Qt] Missing SVG variables
     6        https://bugs.webkit.org/show_bug.cgi?id=32941
     7
     8        Basically, this patch just modifies features.pri to the Qt build to
     9        pass on the ENABLE_SVG_* flags to the IDL binding generator.
     10
     11        Also I had remove global-construtors.html from the skip list and
     12        updated the associated expected results files.
     13
     14        * platform/qt/Skipped:
     15        * platform/qt/fast/dom/Window/window-properties-expected.txt:
     16        * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
     17        * platform/qt/fast/dom/prototype-inheritance-expected.txt:
     18        * platform/qt/fast/js/global-constructors-expected.txt:
     19
    1202011-03-08  David Hyatt  <hyatt@apple.com>
    221

  • trunk/LayoutTests/platform/qt/Skipped

    r80536 r80587  
    819819svg/css/composite-shadow-example.html
    820820svg/css/composite-shadow-with-opacity.html
    821 # Missing variables:
    822 # SVGAltGlyphElement, SVGAnimateElement, SVGAnimateColorElement, SVGAnimateTransformElement
    823 # SVGFontElement, SVGGlyphElement, SVGMissingGlyphElement, SVGFontFaceElement, SVGFontFaceSrcElement
    824 # SVGFontFaceUriElement, SVGFontFaceFormatElement, SVGFontFaceNameElement, SVGForeignObjectElement
    825 # https://bugs.webkit.org/show_bug.cgi?id=32941
    826 svg/custom/global-constructors.html
    827821
    828822# --- to be reviewed

  • trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt

    r78329 r80587  
    13681368window.SVGAElement [object SVGAElementConstructor]
    13691369window.SVGAElement.prototype [printed above as window.Element.prototype]
     1370window.SVGAltGlyphElement [object SVGAltGlyphElementConstructor]
     1371window.SVGAltGlyphElement.prototype [printed above as window.Element.prototype]
    13701372window.SVGAngle [object SVGAngleConstructor]
    13711373window.SVGAngle.SVG_ANGLETYPE_DEG [number]
    … …  
    13821384window.SVGAngle.prototype.convertToSpecifiedUnits [function]
    13831385window.SVGAngle.prototype.newValueSpecifiedUnits [function]
     1386window.SVGAnimateColorElement [object SVGAnimateColorElementConstructor]
     1387window.SVGAnimateColorElement.prototype [printed above as window.Element.prototype]
     1388window.SVGAnimateElement [object SVGAnimateElementConstructor]
     1389window.SVGAnimateElement.prototype [printed above as window.Element.prototype]
     1390window.SVGAnimateTransformElement [object SVGAnimateTransformElementConstructor]
     1391window.SVGAnimateTransformElement.prototype [printed above as window.Element.prototype]
    13841392window.SVGAnimatedAngle [object SVGAnimatedAngleConstructor]
    13851393window.SVGAnimatedAngle.prototype [object SVGAnimatedAnglePrototype]
    … …  
    15391547window.SVGFilterElement [object SVGFilterElementConstructor]
    15401548window.SVGFilterElement.prototype [printed above as window.Element.prototype]
     1549window.SVGFontElement [object SVGFontElementConstructor]
     1550window.SVGFontElement.prototype [printed above as window.Element.prototype]
     1551window.SVGFontFaceElement [object SVGFontFaceElementConstructor]
     1552window.SVGFontFaceElement.prototype [printed above as window.Element.prototype]
     1553window.SVGFontFaceFormatElement [object SVGFontFaceFormatElementConstructor]
     1554window.SVGFontFaceFormatElement.prototype [printed above as window.Element.prototype]
     1555window.SVGFontFaceNameElement [object SVGFontFaceNameElementConstructor]
     1556window.SVGFontFaceNameElement.prototype [printed above as window.Element.prototype]
     1557window.SVGFontFaceSrcElement [object SVGFontFaceSrcElementConstructor]
     1558window.SVGFontFaceSrcElement.prototype [printed above as window.Element.prototype]
     1559window.SVGFontFaceUriElement [object SVGFontFaceUriElementConstructor]
     1560window.SVGFontFaceUriElement.prototype [printed above as window.Element.prototype]
     1561window.SVGForeignObjectElement [object SVGForeignObjectElementConstructor]
     1562window.SVGForeignObjectElement.prototype [printed above as window.Element.prototype]
    15411563window.SVGGElement [object SVGGElementConstructor]
    15421564window.SVGGElement.prototype [printed above as window.Element.prototype]
     1565window.SVGGlyphElement [object SVGGlyphElementConstructor]
     1566window.SVGGlyphElement.prototype [printed above as window.Element.prototype]
    15431567window.SVGGradientElement [object SVGGradientElementConstructor]
    15441568window.SVGGradientElement.SVG_SPREADMETHOD_PAD [number]
    … …  
    15471571window.SVGGradientElement.SVG_SPREADMETHOD_UNKNOWN [number]
    15481572window.SVGGradientElement.prototype [printed above as window.Element.prototype]
     1573window.SVGHKernElement [object SVGHKernElementConstructor]
     1574window.SVGHKernElement.prototype [printed above as window.Element.prototype]
    15491575window.SVGImageElement [object SVGImageElementConstructor]
    15501576window.SVGImageElement.prototype [printed above as window.Element.prototype]
    … …  
    16131639window.SVGMetadataElement [object SVGMetadataElementConstructor]
    16141640window.SVGMetadataElement.prototype [printed above as window.Element.prototype]
     1641window.SVGMissingGlyphElement [object SVGMissingGlyphElementConstructor]
     1642window.SVGMissingGlyphElement.prototype [printed above as window.Element.prototype]
    16151643window.SVGNumber [object SVGNumberConstructor]
    16161644window.SVGNumber.prototype [object SVGNumberPrototype]
    … …  
    18021830window.SVGScriptElement [object SVGScriptElementConstructor]
    18031831window.SVGScriptElement.prototype [printed above as window.Element.prototype]
     1832window.SVGSetElement [object SVGSetElementConstructor]
     1833window.SVGSetElement.prototype [printed above as window.Element.prototype]
    18041834window.SVGStopElement [object SVGStopElementConstructor]
    18051835window.SVGStopElement.prototype [printed above as window.Element.prototype]
    … …  
    18851915window.SVGUseElement [object SVGUseElementConstructor]
    18861916window.SVGUseElement.prototype [printed above as window.Element.prototype]
     1917window.SVGVKernElement [object SVGVKernElementConstructor]
     1918window.SVGVKernElement.prototype [printed above as window.Element.prototype]
    18871919window.SVGViewElement [object SVGViewElementConstructor]
    18881920window.SVGViewElement.SVG_ZOOMANDPAN_DISABLE [number]

  • trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt

    r76212 r80587  
    166166PASS typeof Object.getOwnPropertyDescriptor(window, 'SQLException') is 'object'
    167167PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAElement') is 'object'
     168PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAltGlyphElement') is 'object'
    168169PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAngle') is 'object'
     170PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAnimateColorElement') is 'object'
     171PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAnimateElement') is 'object'
     172PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAnimateTransformElement') is 'object'
    169173PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAnimatedAngle') is 'object'
    170174PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAnimatedBoolean') is 'object'
    … …  
    217221PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGFETurbulenceElement') is 'object'
    218222PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGFilterElement') is 'object'
     223PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGFontElement') is 'object'
     224PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGFontFaceElement') is 'object'
     225PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGFontFaceFormatElement') is 'object'
     226PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGFontFaceNameElement') is 'object'
     227PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGFontFaceSrcElement') is 'object'
     228PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGFontFaceUriElement') is 'object'
     229PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGForeignObjectElement') is 'object'
    219230PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGGElement') is 'object'
     231PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGGlyphElement') is 'object'
    220232PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGGradientElement') is 'object'
     233PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGHKernElement') is 'object'
    221234PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGImageElement') is 'object'
    222235PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGLength') is 'object'
    … …  
    228241PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGMatrix') is 'object'
    229242PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGMetadataElement') is 'object'
     243PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGMissingGlyphElement') is 'object'
    230244PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGNumber') is 'object'
    231245PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGNumberList') is 'object'
    … …  
    265279PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGSVGElement') is 'object'
    266280PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGScriptElement') is 'object'
     281PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGSetElement') is 'object'
    267282PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGStopElement') is 'object'
    268283PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGStringList') is 'object'
    … …  
    281296PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGUnitTypes') is 'object'
    282297PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGUseElement') is 'object'
     298PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGVKernElement') is 'object'
    283299PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGViewElement') is 'object'
    284300PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGZoomEvent') is 'object'

  • trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-expected.txt

    r78329 r80587  
    320320PASS inner.SVGAElement.isInner is true
    321321PASS inner.SVGAElement.constructor.isInner is true
     322PASS inner.SVGAltGlyphElement.isInner is true
     323PASS inner.SVGAltGlyphElement.constructor.isInner is true
    322324PASS inner.SVGAngle.isInner is true
    323325PASS inner.SVGAngle.constructor.isInner is true
     326PASS inner.SVGAnimateColorElement.isInner is true
     327PASS inner.SVGAnimateColorElement.constructor.isInner is true
     328PASS inner.SVGAnimateElement.isInner is true
     329PASS inner.SVGAnimateElement.constructor.isInner is true
     330PASS inner.SVGAnimateTransformElement.isInner is true
     331PASS inner.SVGAnimateTransformElement.constructor.isInner is true
    324332PASS inner.SVGAnimatedAngle.isInner is true
    325333PASS inner.SVGAnimatedAngle.constructor.isInner is true
    … …  
    422430PASS inner.SVGFilterElement.isInner is true
    423431PASS inner.SVGFilterElement.constructor.isInner is true
     432PASS inner.SVGFontElement.isInner is true
     433PASS inner.SVGFontElement.constructor.isInner is true
     434PASS inner.SVGFontFaceElement.isInner is true
     435PASS inner.SVGFontFaceElement.constructor.isInner is true
     436PASS inner.SVGFontFaceFormatElement.isInner is true
     437PASS inner.SVGFontFaceFormatElement.constructor.isInner is true
     438PASS inner.SVGFontFaceNameElement.isInner is true
     439PASS inner.SVGFontFaceNameElement.constructor.isInner is true
     440PASS inner.SVGFontFaceSrcElement.isInner is true
     441PASS inner.SVGFontFaceSrcElement.constructor.isInner is true
     442PASS inner.SVGFontFaceUriElement.isInner is true
     443PASS inner.SVGFontFaceUriElement.constructor.isInner is true
     444PASS inner.SVGForeignObjectElement.isInner is true
     445PASS inner.SVGForeignObjectElement.constructor.isInner is true
    424446PASS inner.SVGGElement.isInner is true
    425447PASS inner.SVGGElement.constructor.isInner is true
     448PASS inner.SVGGlyphElement.isInner is true
     449PASS inner.SVGGlyphElement.constructor.isInner is true
    426450PASS inner.SVGGradientElement.isInner is true
    427451PASS inner.SVGGradientElement.constructor.isInner is true
     452PASS inner.SVGHKernElement.isInner is true
     453PASS inner.SVGHKernElement.constructor.isInner is true
    428454PASS inner.SVGImageElement.isInner is true
    429455PASS inner.SVGImageElement.constructor.isInner is true
    … …  
    444470PASS inner.SVGMetadataElement.isInner is true
    445471PASS inner.SVGMetadataElement.constructor.isInner is true
     472PASS inner.SVGMissingGlyphElement.isInner is true
     473PASS inner.SVGMissingGlyphElement.constructor.isInner is true
    446474PASS inner.SVGNumber.isInner is true
    447475PASS inner.SVGNumber.constructor.isInner is true
    … …  
    518546PASS inner.SVGScriptElement.isInner is true
    519547PASS inner.SVGScriptElement.constructor.isInner is true
     548PASS inner.SVGSetElement.isInner is true
     549PASS inner.SVGSetElement.constructor.isInner is true
    520550PASS inner.SVGStopElement.isInner is true
    521551PASS inner.SVGStopElement.constructor.isInner is true
    … …  
    550580PASS inner.SVGUseElement.isInner is true
    551581PASS inner.SVGUseElement.constructor.isInner is true
     582PASS inner.SVGVKernElement.isInner is true
     583PASS inner.SVGVKernElement.constructor.isInner is true
    552584PASS inner.SVGViewElement.isInner is true
    553585PASS inner.SVGViewElement.constructor.isInner is true

  • trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt

    r76212 r80587  
    151151PASS SQLException.toString() is '[object SQLExceptionConstructor]'
    152152PASS SVGAElement.toString() is '[object SVGAElementConstructor]'
     153PASS SVGAltGlyphElement.toString() is '[object SVGAltGlyphElementConstructor]'
    153154PASS SVGAngle.toString() is '[object SVGAngleConstructor]'
     155PASS SVGAnimateColorElement.toString() is '[object SVGAnimateColorElementConstructor]'
     156PASS SVGAnimateElement.toString() is '[object SVGAnimateElementConstructor]'
     157PASS SVGAnimateTransformElement.toString() is '[object SVGAnimateTransformElementConstructor]'
    154158PASS SVGAnimatedAngle.toString() is '[object SVGAnimatedAngleConstructor]'
    155159PASS SVGAnimatedBoolean.toString() is '[object SVGAnimatedBooleanConstructor]'
    … …  
    202206PASS SVGFETurbulenceElement.toString() is '[object SVGFETurbulenceElementConstructor]'
    203207PASS SVGFilterElement.toString() is '[object SVGFilterElementConstructor]'
     208PASS SVGFontElement.toString() is '[object SVGFontElementConstructor]'
     209PASS SVGFontFaceElement.toString() is '[object SVGFontFaceElementConstructor]'
     210PASS SVGFontFaceFormatElement.toString() is '[object SVGFontFaceFormatElementConstructor]'
     211PASS SVGFontFaceNameElement.toString() is '[object SVGFontFaceNameElementConstructor]'
     212PASS SVGFontFaceSrcElement.toString() is '[object SVGFontFaceSrcElementConstructor]'
     213PASS SVGFontFaceUriElement.toString() is '[object SVGFontFaceUriElementConstructor]'
     214PASS SVGForeignObjectElement.toString() is '[object SVGForeignObjectElementConstructor]'
    204215PASS SVGGElement.toString() is '[object SVGGElementConstructor]'
     216PASS SVGGlyphElement.toString() is '[object SVGGlyphElementConstructor]'
    205217PASS SVGGradientElement.toString() is '[object SVGGradientElementConstructor]'
     218PASS SVGHKernElement.toString() is '[object SVGHKernElementConstructor]'
    206219PASS SVGImageElement.toString() is '[object SVGImageElementConstructor]'
    207220PASS SVGLength.toString() is '[object SVGLengthConstructor]'
    … …  
    213226PASS SVGMatrix.toString() is '[object SVGMatrixConstructor]'
    214227PASS SVGMetadataElement.toString() is '[object SVGMetadataElementConstructor]'
     228PASS SVGMissingGlyphElement.toString() is '[object SVGMissingGlyphElementConstructor]'
    215229PASS SVGNumber.toString() is '[object SVGNumberConstructor]'
    216230PASS SVGNumberList.toString() is '[object SVGNumberListConstructor]'
    … …  
    250264PASS SVGSVGElement.toString() is '[object SVGSVGElementConstructor]'
    251265PASS SVGScriptElement.toString() is '[object SVGScriptElementConstructor]'
     266PASS SVGSetElement.toString() is '[object SVGSetElementConstructor]'
    252267PASS SVGStopElement.toString() is '[object SVGStopElementConstructor]'
    253268PASS SVGStringList.toString() is '[object SVGStringListConstructor]'
    … …  
    266281PASS SVGUnitTypes.toString() is '[object SVGUnitTypesConstructor]'
    267282PASS SVGUseElement.toString() is '[object SVGUseElementConstructor]'
     283PASS SVGVKernElement.toString() is '[object SVGVKernElementConstructor]'
    268284PASS SVGViewElement.toString() is '[object SVGViewElementConstructor]'
    269285PASS SVGZoomEvent.toString() is '[object SVGZoomEventConstructor]'

  • trunk/Source/WebCore/ChangeLog

    r80584 r80587  
     12011-03-08  Joe Wild  <joseph.wild@nokia.com>
     2
     3        Reviewed by Csaba Osztrogonác.
     4
     5        [Qt] Missing SVG variables
     6        https://bugs.webkit.org/show_bug.cgi?id=32941
     7
     8        Basically, this patch just modifies features.pri to the Qt build to
     9        pass on the ENABLE_SVG_* flags to the IDL binding generator.
     10
     11        Also I had remove global-construtors.html from the skip list and
     12        updated the associated expected results files.
     13
     14        * features.pri:
     15        * page/DOMWindow.idl:
     16
    1172011-03-08  Alok priyadarshi  <alokp@chromium.org>
    218

  • trunk/Source/WebCore/features.pri

    r80424 r80587  
    215215contains(DEFINES, ENABLE_XHTMLMP=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_XHTMLMP=1
    216216contains(DEFINES, ENABLE_SVG=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_SVG=1
     217contains(DEFINES, ENABLE_SVG_ANIMATION=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_SVG_ANIMATION=1
     218contains(DEFINES, ENABLE_SVG_FONTS=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_SVG_FONTS=1
     219contains(DEFINES, ENABLE_SVG_FOREIGN_OBJECT=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_SVG_FOREIGN_OBJECT=1
    217220contains(DEFINES, ENABLE_JAVASCRIPT_DEBUGGER=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_JAVASCRIPT_DEBUGGER=1
    218221contains(DEFINES, ENABLE_OFFLINE_WEB_APPLICATIONS=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_OFFLINE_WEB_APPLICATIONS=1

  • trunk/Source/WebCore/page/DOMWindow.idl

    r79917 r80587  
    721721#endif
    722722
    723 #if ENABLE_SVG_FONTS && ENABLE_SVG_FONTS
     723#if defined(ENABLE_SVG_FONTS) && ENABLE_SVG_FONTS
    724724//      attribute SVGAltGlyphDefElementConstructor SVGAltGlyphDefElement;
    725725        attribute SVGAltGlyphElementConstructor SVGAltGlyphElement;
Note: See TracChangeset for help on using the changeset viewer.