Changeset 80796 in webkit

Timestamp:

Mar 10, 2011 5:13:56 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-03-10 Viatcheslav Ostapenko <​ostapenko.viatcheslav@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Text layout is broken on Symbian
​https://bugs.webkit.org/show_bug.cgi?id=56046

Change integers included into bitfields to be signed by default on RVCT
compiler as a lot of other compilers do (gcc, msvc, winsc).
There are a lot of places in webkit where integers included in bitfield
are assumed to be signed.

• Source/WebKit.pri:

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/WebKit.pri (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2011-03-10  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
+
+        Reviewed by Laszlo Gombos.
+
+        [Qt] Text layout is broken on Symbian
+        https://bugs.webkit.org/show_bug.cgi?id=56046
+
+        Change integers included into bitfields to be signed by default on RVCT
+        compiler as a lot of other compilers do (gcc, msvc, winsc).
+        There are a lot of places in webkit where integers included in bitfield
+        are assumed to be signed.
+
+        * Source/WebKit.pri:
+
 2011-03-10  Alejandro G. Castro  <alex@igalia.com>
 

trunk/Source/WebKit.pri

@@ -94 +94 @@
 symbian|*-armcc {
     # Enable GNU compiler extensions to the ARM compiler for all Qt ports using RVCT
-    RVCT_COMMON_CFLAGS = --gnu --diag_suppress 68,111,177,368,830,1293
+    RVCT_COMMON_CFLAGS = --gnu --diag_suppress 68,111,177,368,830,1293 --signed_bitfields
     RVCT_COMMON_CXXFLAGS = $$RVCT_COMMON_CFLAGS --no_parse_templates
     # Make debug symbols leaner in RVCT4.x. Ignored by compiler for release builds