Changeset 80808 in webkit


Ignore:
Timestamp:
Mar 10, 2011 8:22:49 PM (13 years ago)
Author:
eae@chromium.org
Message:

2011-03-10 Emil A Eklund <eae@chromium.org>

Reviewed by Dimitri Glazkov.

style.display affecting the initial selectedIndex value of a <select> when it's multiple attribute is set programatically
https://bugs.webkit.org/show_bug.cgi?id=53860

Add tests for selectedIndex when changing the multiple property on a select element.

  • fast/dom/HTMLSelectElement/change-multiple-preserve-selection-expected.txt: Added.
  • fast/dom/HTMLSelectElement/change-multiple-preserve-selection.html: Added.

2011-03-10 Emil A Eklund <eae@chromium.org>

Reviewed by Dimitri Glazkov.

style.display affecting the initial selectedIndex value of a <select> when its multiple attribute is set programatically
https://bugs.webkit.org/show_bug.cgi?id=53860

Preserve selection when changing between multi-select and single-select
for <select> boxes even if it has not yet been rendered.

Test: fast/dom/HTMLSelectElement/change-multiple-preserve-selection.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setMultiple):
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r80806 r80808  
     12011-03-10  Emil A Eklund  <eae@chromium.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        style.display affecting the initial selectedIndex value of a <select> when it's multiple attribute is set programatically
     6        https://bugs.webkit.org/show_bug.cgi?id=53860
     7
     8        Add tests for selectedIndex when changing the multiple property on a select element.
     9
     10        * fast/dom/HTMLSelectElement/change-multiple-preserve-selection-expected.txt: Added.
     11        * fast/dom/HTMLSelectElement/change-multiple-preserve-selection.html: Added.
     12
    1132011-03-10  Rik Cabanier  <cabanier@gmail.com>
    214
  • trunk/Source/WebCore/ChangeLog

    r80807 r80808  
     12011-03-10  Emil A Eklund  <eae@chromium.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        style.display affecting the initial selectedIndex value of a <select> when its multiple attribute is set programatically
     6        https://bugs.webkit.org/show_bug.cgi?id=53860
     7
     8        Preserve selection when changing between multi-select and single-select
     9        for <select> boxes even if it has not yet been rendered.
     10
     11        Test: fast/dom/HTMLSelectElement/change-multiple-preserve-selection.html
     12
     13        * html/HTMLSelectElement.cpp:
     14        (WebCore::HTMLSelectElement::setMultiple):
     15
    1162011-03-10  Ojan Vafai  <ojan@chromium.org>
    217
  • trunk/Source/WebCore/html/HTMLSelectElement.cpp

    r78150 r80808  
    435435void HTMLSelectElement::setMultiple(bool multiple)
    436436{
     437    int oldSelectedIndex = selectedIndex();
    437438    setAttribute(multipleAttr, multiple ? "" : 0);
     439
     440    // Restore selectedIndex after changing the multiple flag to preserve
     441    // selection as single-line and multi-line has different defaults.
     442    setSelectedIndex(oldSelectedIndex);
    438443}
    439444
Note: See TracChangeset for help on using the changeset viewer.