Changeset 80840 in webkit

Timestamp:

Mar 11, 2011 3:23:02 AM (13 years ago)

Author:

apavlov@chromium.org

Message:

2011-03-11 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: hover over elements in Elements panel does not highlight nodes
​https://bugs.webkit.org/show_bug.cgi?id=56121

In DOM trees with a comment and/or doctype preceding the HTML tag, the tree container right boundary
is 16px apart from the OL right boundary, and we miss the relevant LI by 4px. The fix is to compensate
for these 16px when computing the test point coordinates.

• inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/ElementsTreeOutline.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-03-11  Alexander Pavlov  <apavlov@chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: hover over elements in Elements panel does not highlight nodes
+        https://bugs.webkit.org/show_bug.cgi?id=56121
+
+        In DOM trees with a comment and/or doctype preceding the HTML tag, the tree container right boundary
+        is 16px apart from the OL right boundary, and we miss the relevant LI by 4px. The fix is to compensate
+        for these 16px when computing the test point coordinates.
+
+        * inspector/front-end/ElementsTreeOutline.js:
+        (WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
+
 2011-03-11  Yury Semikhatsky  <yurys@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js

@@ -194 +194 @@
         // In the no-word-wrap mode the outer <ol> may be wider than the tree container
         // (and partially hidden), in which case we are left to use only its right boundary.
-        var x = scrollContainer.totalOffsetLeft + scrollContainer.offsetWidth - 20;
+        var x = scrollContainer.totalOffsetLeft + scrollContainer.offsetWidth - 36;
 
         var y = event.pageY;