Changeset 80871 in webkit


Ignore:
Timestamp:
Mar 11, 2011 12:13:09 PM (13 years ago)
Author:
hyatt@apple.com
Message:

​https://bugs.webkit.org/show_bug.cgi?id=47206

Reviewed by Dan Bernstein.

Table rows don't support ::before/::after. Add support to RenderTableRow::styleDidChange so that ::before/::after content gets
properly constructed.

Added fast/css-generated-content/table-row-before-after.html

Source/WebCore:

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::styleDidChange):

  • rendering/RenderTableRow.h:

LayoutTests:

  • fast/css-generated-content/table-row-before-after.html: Added.
  • platform/mac/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
  • platform/mac/fast/css-generated-content/table-row-before-after-expected.png: Added.
  • platform/mac/fast/css-generated-content/table-row-before-after-expected.txt: Added.
Location:
trunk
Files:
4 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r80868 r80871  
     12011-03-11  David Hyatt  <hyatt@apple.com>
     2
     3        Reviewed by Dan Bernstein.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=47206
     6       
     7        Table rows don't support ::before/::after.  Add support to RenderTableRow::styleDidChange so that ::before/::after content gets
     8        properly constructed.
     9
     10        Added fast/css-generated-content/table-row-before-after.html
     11
     12        * fast/css-generated-content/table-row-before-after.html: Added.
     13        * platform/mac/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
     14        * platform/mac/fast/css-generated-content/table-row-before-after-expected.png: Added.
     15        * platform/mac/fast/css-generated-content/table-row-before-after-expected.txt: Added.
     16
    1172011-03-11  David Hyatt  <hyatt@apple.com>
    218

  • trunk/Source/WebCore/ChangeLog

    r80869 r80871  
     12011-03-11  David Hyatt  <hyatt@apple.com>
     2
     3        Reviewed by Dan Bernstein.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=47206
     6       
     7        Table rows don't support ::before/::after.  Add support to RenderTableRow::styleDidChange so that ::before/::after content gets
     8        properly constructed.
     9
     10        Added fast/css-generated-content/table-row-before-after.html
     11
     12        * rendering/RenderTableRow.cpp:
     13        (WebCore::RenderTableRow::styleDidChange):
     14        * rendering/RenderTableRow.h:
     15
    1162011-03-11  James Robinson  <jamesr@chromium.org>
    217

  • trunk/Source/WebCore/rendering/RenderTableRow.cpp

    r76726 r80871  
    6464}
    6565
     66void RenderTableRow::styleDidChange(StyleDifference diff, const RenderStyle* oldStyle)
     67{
     68    RenderBox::styleDidChange(diff, oldStyle);
     69
     70    // Update pseudos for :before and :after now.
     71    if (!isAnonymous() && document()->usesBeforeAfterRules()) {
     72        children()->updateBeforeAfterContent(this, BEFORE);
     73        children()->updateBeforeAfterContent(this, AFTER);
     74    }
     75}
     76
    6677void RenderTableRow::addChild(RenderObject* child, RenderObject* beforeChild)
    6778{

  • trunk/Source/WebCore/rendering/RenderTableRow.h

    r70072 r80871  
    6363
    6464    virtual void styleWillChange(StyleDifference, const RenderStyle* newStyle);
     65    virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle);
    6566
    6667    RenderObjectChildList m_children;
Note: See TracChangeset for help on using the changeset viewer.