Changeset 81128 in webkit

Timestamp:

Mar 15, 2011 3:47:29 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-03-15 Chris Mumford <​chris.mumford@palm.com>

Reviewed by Adam Barth.

Initializing several member variables that were not initialized in
their constructors. These values were all read prior to initialization
as reported by Valgrind.

No new tests: No feature additions/removals.

• accessibility/AccessibilityImageMapLink.cpp: (WebCore::AccessibilityImageMapLink::AccessibilityImageMapLink):
• editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand):
• html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::HTMLCanvasElement):
• xml/XPathResult.cpp: (WebCore::XPathResult::XPathResult):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/AccessibilityImageMapLink.cpp (modified) (1 diff)
• editing/DeleteSelectionCommand.cpp (modified) (2 diffs)
• html/HTMLCanvasElement.cpp (modified) (1 diff)
• xml/XPathResult.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-03-15  Chris Mumford  <chris.mumford@palm.com>
+
+        Reviewed by Adam Barth.
+
+        Initializing several member variables that were not initialized in
+        their constructors. These values were all read prior to initialization
+        as reported by Valgrind.
+
+        No new tests: No feature additions/removals.
+
+        * accessibility/AccessibilityImageMapLink.cpp:
+        (WebCore::AccessibilityImageMapLink::AccessibilityImageMapLink):
+        * editing/DeleteSelectionCommand.cpp:
+        (WebCore::DeleteSelectionCommand::DeleteSelectionCommand):
+        * html/HTMLCanvasElement.cpp:
+        (WebCore::HTMLCanvasElement::HTMLCanvasElement):
+        * xml/XPathResult.cpp:
+        (WebCore::XPathResult::XPathResult):
+
 2011-03-15  Ben Taylor  <bentaylor.solx86@gmail.com>
 

trunk/Source/WebCore/accessibility/AccessibilityImageMapLink.cpp

@@ -43 +43 @@
     : m_areaElement(0)
     , m_mapElement(0)
+    , m_parent(0)
 {
 }

trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp

@@ -73 +73 @@
       m_smartDelete(smartDelete), 
       m_mergeBlocksAfterDelete(mergeBlocksAfterDelete),
+      m_needPlaceholder(false),
       m_replace(replace),
       m_expandForSpecialElements(expandForSpecialElements),
@@ -89 +90 @@
       m_smartDelete(smartDelete), 
       m_mergeBlocksAfterDelete(mergeBlocksAfterDelete),
+      m_needPlaceholder(false),
       m_replace(replace),
       m_expandForSpecialElements(expandForSpecialElements),

trunk/Source/WebCore/html/HTMLCanvasElement.cpp

@@ -77 +77 @@
     : HTMLElement(tagName, document)
     , m_size(DefaultWidth, DefaultHeight)
+    , m_rendererIsCanvas(false)
     , m_ignoreReset(false)
     , m_pageScaleFactor(document->frame() ? document->frame()->page()->chrome()->scaleFactor() : 1)

trunk/Source/WebCore/xml/XPathResult.cpp

@@ -42 +42 @@
 XPathResult::XPathResult(Document* document, const Value& value)
     : m_value(value)
+    , m_nodeSetPosition(0)
+    , m_domTreeVersion(0)
 {
     switch (m_value.type()) {